Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger to graph types #1305

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Add logger to graph types #1305

merged 1 commit into from
Dec 23, 2019

Conversation

ukclivecox
Copy link
Contributor

Allows logging at any point in the graph.
This feature will need to be added to the engine and its replacement the executor.
Eventually we will at v2alpha1 types but as types need to be backwards compatible we will extend v1 for now.

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Mon Dec 23 08:50:29 UTC 2019
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1305/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1305 --build=1

@seldondev
Copy link
Collaborator

Mon Dec 23 08:50:41 UTC 2019
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1305/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1305 --build=2

@seldondev
Copy link
Collaborator

Mon Dec 23 08:50:53 UTC 2019
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1305/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1305 --build=3

@axsaucedo
Copy link
Contributor

/approve
/lgtm

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 3b37261 into SeldonIO:master Dec 23, 2019
@ukclivecox ukclivecox deleted the 1293_request_logger branch February 14, 2020 11:38
@axsaucedo axsaucedo removed their assignment May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants