Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tensorflow==2.1 in outliers example #1358

Merged
merged 1 commit into from
Jan 22, 2020
Merged

fix tensorflow==2.1 in outliers example #1358

merged 1 commit into from
Jan 22, 2020

Conversation

RafalSkolasinski
Copy link
Contributor

Outliers example depends on both alibi and alib-detect.
These two have contradicting dependency on tensorflow, former one currently requiring TF<2 and latter requiring TF>=2.0 .

Because in outliers detector example we use alibi to only fetch a dataset this tiny PR fixes tensorflow to be compatible with alibi-detect.

@seldondev
Copy link
Collaborator

Wed Jan 22 15:10:47 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1358/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1358 --build=1

@seldondev
Copy link
Collaborator

Wed Jan 22 15:10:53 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1358/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1358 --build=2

@axsaucedo
Copy link
Contributor

Nice one
/approve
/lgtm

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 87fe3f9 into SeldonIO:master Jan 22, 2020
@axsaucedo axsaucedo removed their assignment May 13, 2021
@seldondev
Copy link
Collaborator

failed to trigger Pull Request pipeline

  • failed to create agent
  • failed to calculate in repo config
  • failed to load trigger config for repository SeldonIO/seldon-core for ref d5d1583
  • failed to find any lighthouse configuration files in repo SeldonIO/seldon-core at sha d5d1583
  • failed to process repo SeldonIO/seldon-core refref d5d1583
  • failed to list files in directory /var/tmp/gitrepo660600678/.lighthouse
  • open /var/tmp/gitrepo660600678/.lighthouse
  • no such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants