-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pandas from 0.25.3 to 1.0.0 in /python #1397
Conversation
Hi @dependabot-preview[bot]. Thanks for your PR. I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Mon Feb 3 09:08:57 UTC 2020 impatient try |
Mon Feb 3 09:09:05 UTC 2020 impatient try |
@adriangonz I can only see one usage of pandas in Seldon Core outside of the examples folder, so maybe would be best to explore whether that dependency can be removed. @jklaise is there any other areas where Seldon Core is using pandas? |
Not that I'm aware of. |
It's also used on the
/test lint |
Mon Feb 3 12:13:06 UTC 2020 impatient try |
/test lint |
5 similar comments
/test lint |
/test lint |
/test lint |
/test lint |
/test lint |
Mon Feb 3 12:23:15 UTC 2020 impatient try |
Mon Feb 3 12:31:14 UTC 2020 impatient try |
Mon Feb 3 12:31:24 UTC 2020 impatient try |
Good idea @adriangonz - I think as long as this is not used anywhere else then should eb good. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Mon Feb 3 12:35:38 UTC 2020 impatient try |
/test integration |
Mon Feb 3 14:42:41 UTC 2020 impatient try |
The error on the integration tests was probably related to #1402. I've run them locally and they pass. |
A newer version of pandas exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Bumps [pandas](https://github.com/pandas-dev/pandas) from 0.25.3 to 1.0.0. - [Release notes](https://github.com/pandas-dev/pandas/releases) - [Changelog](https://github.com/pandas-dev/pandas/blob/master/RELEASE.md) - [Commits](pandas-dev/pandas@v0.25.3...v1.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
74edb31
to
a2a25d8
Compare
New changes are detected. LGTM label has been removed. |
/test integration |
Tue Feb 11 15:25:16 UTC 2020 impatient try |
Tue Feb 11 15:26:17 UTC 2020 impatient try |
Tue Feb 11 15:26:51 UTC 2020 impatient try |
Bumps pandas from 0.25.3 to 1.0.0.
Release notes
Sourced from pandas's releases.
Commits
fd9ceb9
RLS: 1.0.08d7a40e
Backport PR #31430: release date (#31432)694e92c
DOC: separate section with experimental features in 1.0.0 whatsnew (#31429) (...bfa2b9e
BUG: regression when applying groupby aggregation on categorical columns (#31...05a0b63
Backport PR #31423: PERF: postpone imports in Index constructor (#31424)c62e6c0
Backport PR #31411: COMPAT: dont pass dtype to datetime64 (#31421)d633915
API: generalized check_array_indexer for validating array-like getitem indexe...a08c2f9
Backport PR #31361: Avoid Index DeprecationWarning in Series getitem (#31403)af208b3
Backport PR #31136: COMPAT: Return NotImplemented for subclassing (#31405)c836828
"Backport PR #31358 on branch 1.0.x" (#31376)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in the
.dependabot/config.yml
file in this repo: