improve reliability of req logging under high load #1457
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noted that under high load elastic can give transport errors. Could add more elastic nodes but this reduces requests to elastic and makes it more likely that docs will be indexed. On my testing all docs were being indexed that hit the logger, both request and response. When pointing to the logger directly that was simply all docs (when going via knative broker I found processing was much faster but the in-memory broker seemed to lose about a response per thousand).