Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve reliability of req logging under high load #1457

Merged

Conversation

ryandawsonuk
Copy link
Contributor

@ryandawsonuk ryandawsonuk commented Feb 17, 2020

Noted that under high load elastic can give transport errors. Could add more elastic nodes but this reduces requests to elastic and makes it more likely that docs will be indexed. On my testing all docs were being indexed that hit the logger, both request and response. When pointing to the logger directly that was simply all docs (when going via knative broker I found processing was much faster but the in-memory broker seemed to lose about a response per thousand).

@seldondev
Copy link
Collaborator

Mon Feb 17 12:09:16 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1457/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1457 --build=2

@seldondev
Copy link
Collaborator

Mon Feb 17 12:09:32 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1457/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1457 --build=1

@ryandawsonuk
Copy link
Contributor Author

/lgtm
/approve

@seldondev
Copy link
Collaborator

@ryandawsonuk: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit b89a42b into SeldonIO:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants