Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup examples #1495

Merged
merged 5 commits into from
Mar 13, 2020
Merged

Cleanup examples #1495

merged 5 commits into from
Mar 13, 2020

Conversation

ukclivecox
Copy link
Contributor

Fixes #1467

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@seldondev
Copy link
Collaborator

Tue Mar 3 09:24:55 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1495/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1495 --build=2

@seldondev
Copy link
Collaborator

Tue Mar 3 09:25:08 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1495/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1495 --build=1

@seldondev
Copy link
Collaborator

Mon Mar 9 14:04:47 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1495/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1495 --build=3

@seldondev
Copy link
Collaborator

Mon Mar 9 14:04:51 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1495/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1495 --build=4

@ukclivecox ukclivecox changed the title WIP: cleanup examples Cleanup examples Mar 11, 2020
@ukclivecox ukclivecox requested a review from axsaucedo March 11, 2020 19:09
@seldondev
Copy link
Collaborator

Wed Mar 11 19:10:30 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1495/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1495 --build=5

@seldondev
Copy link
Collaborator

Wed Mar 11 19:10:47 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1495/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1495 --build=6

@axsaucedo
Copy link
Contributor

Looks good - only thing I think it may be good to leave the Tensorflow MNIST as it's referenced in quite a few places as links, but other than that looks good @cliveseldon

@axsaucedo
Copy link
Contributor

As discussed deep mnist link was typo as there is no notebook, so just removed dead link
/approve
/lgtm

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Fri Mar 13 08:34:13 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1495/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1495 --build=8

@seldondev
Copy link
Collaborator

Fri Mar 13 08:35:33 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1495/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1495 --build=7

@seldondev seldondev merged commit c4ee4e3 into SeldonIO:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up examples
3 participants