Explainer Gateway Fix for Istio, Ambassador and Python Client #1668

axsaucedo · 2020-04-06T17:10:06Z

axsaucedo · 2020-04-06T17:10:12Z

/test integration

seldondev · 2020-04-06T17:11:28Z

Mon Apr 6 17:11:27 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=1

seldondev · 2020-04-06T17:11:28Z

Mon Apr 6 17:11:28 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=3

seldondev · 2020-04-06T17:13:06Z

Mon Apr 6 17:13:04 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=2

axsaucedo · 2020-04-06T19:20:50Z

/test integration

seldondev · 2020-04-06T19:21:22Z

Mon Apr 6 19:21:21 UTC 2020
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=5

seldondev · 2020-04-06T19:22:09Z

Mon Apr 6 19:22:08 UTC 2020
The logs for [integration] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=6

seldondev · 2020-04-06T19:22:29Z

Mon Apr 6 19:22:28 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=4

…iner_gateway_fix

axsaucedo · 2020-04-06T19:54:57Z

/test integration

seldondev · 2020-04-06T19:55:43Z

Mon Apr 6 19:55:42 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=8

seldondev · 2020-04-06T19:55:54Z

Mon Apr 6 19:55:53 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=7

seldondev · 2020-04-06T19:56:24Z

Mon Apr 6 19:56:23 UTC 2020
The logs for [integration] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=9

axsaucedo · 2020-04-06T20:01:25Z

/test integration

seldondev · 2020-04-06T20:01:48Z

Mon Apr 6 20:01:47 UTC 2020
The logs for [lint] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=11

seldondev · 2020-04-06T20:01:51Z

Mon Apr 6 20:01:50 UTC 2020
The logs for [pr-build] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=10

seldondev · 2020-04-06T20:03:18Z

Mon Apr 6 20:03:17 UTC 2020
The logs for [integration] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=12

axsaucedo · 2020-04-06T21:35:39Z

/test integration

seldondev · 2020-04-06T21:37:25Z

Mon Apr 6 21:37:24 UTC 2020
The logs for [integration] [15] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/15.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=15

seldondev · 2020-04-08T17:57:16Z

Wed Apr 8 17:57:15 UTC 2020
The logs for [lint] [27] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/27.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=27

seldondev · 2020-04-08T17:57:21Z

Wed Apr 8 17:57:19 UTC 2020
The logs for [pr-build] [26] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/26.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=26

seldondev · 2020-04-09T08:20:50Z

Thu Apr 9 08:20:49 UTC 2020
The logs for [pr-build] [28] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/28.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=28

seldondev · 2020-04-09T08:20:57Z

Thu Apr 9 08:20:56 UTC 2020
The logs for [lint] [29] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/29.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=29

seldondev · 2020-04-09T09:03:08Z

Thu Apr 9 09:03:06 UTC 2020
The logs for [pr-build] [30] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/30.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=30

seldondev · 2020-04-09T09:03:09Z

Thu Apr 9 09:03:07 UTC 2020
The logs for [lint] [31] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/31.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=31

adriangonz

Awesome! I've added a few comments, but it looks pretty good!

python/seldon_core/seldon_client.py

testing/scripts/seldon_e2e_utils.py

testing/scripts/test_prepackaged_servers.py

adriangonz · 2020-04-09T09:53:12Z

operator/controllers/seldondeployment_explainers.go

@@ -247,7 +247,7 @@ func createExplainerIstioResources(pSvcName string, p *machinelearningv1.Predict
 						{
 							Uri: &istio_networking.StringMatch{MatchType: &istio_networking.StringMatch_Prefix{Prefix: "/seldon.protos.Seldon/"}},
 							Headers: map[string]*istio_networking.StringMatch{
-								"seldon":    &istio_networking.StringMatch{MatchType: &istio_networking.StringMatch_Exact{Exact: mlDep.Name}},
+								"seldon":    &istio_networking.StringMatch{MatchType: &istio_networking.StringMatch_Exact{Exact: mlDep.GetName()}},


Interesting, I didn't know that ObjectMeta also had methods defined!

No, those are methods that we added via composition, it's really one that we added to make the name with a hash if too long. Actually, this may have been intended tho - @cliveseldon could you confirm if this was intended?

Which code are you referring to?

oh - those are just convenience methods added by k8s. name and GetName are the same.

adriangonz · 2020-04-09T09:54:27Z

python/seldon_core/seldon_client.py

@@ -528,6 +529,7 @@ def explain(
        headers: Dict = None,
        http_path: str = None,
        client_return_type: str = None,
+        predictor: str = None,


nit (feel free to ignore): should we call the arg predictor_name instead of predictor?

Haha I thought of the same, I think the reason I ended up goign with this is because there were no other params with the format x_name, i.e. method, gateway, namespace, etc

There is deployment_name actually!

seldon-core/python/seldon_core/seldon_client.py

Line 158 in f79d58c

deployment_name: str = None,

seldondev · 2020-04-09T14:00:59Z

Thu Apr 9 14:00:58 UTC 2020
The logs for [pr-build] [32] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/32.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=32

seldondev · 2020-04-09T14:01:10Z

Thu Apr 9 14:01:10 UTC 2020
The logs for [lint] [33] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/33.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=33

ukclivecox · 2020-04-11T08:35:45Z

/test integration

seldondev · 2020-04-11T08:37:43Z

Sat Apr 11 08:37:42 UTC 2020
The logs for [integration] [34] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/34.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=34

ukclivecox · 2020-04-11T08:43:01Z

/approve

seldondev · 2020-04-11T08:43:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cliveseldon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…iner_gateway_fix

axsaucedo · 2020-04-14T09:37:19Z

/test integration

seldondev · 2020-04-14T09:37:35Z

Tue Apr 14 09:37:34 UTC 2020
The logs for [lint] [36] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/36.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=36

seldondev · 2020-04-14T09:37:38Z

Tue Apr 14 09:37:37 UTC 2020
The logs for [pr-build] [35] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/35.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=35

seldondev · 2020-04-14T09:38:39Z

Tue Apr 14 09:38:38 UTC 2020
The logs for [integration] [37] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/37.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=37

seldondev · 2020-04-14T11:25:06Z

Tue Apr 14 11:25:04 UTC 2020
The logs for [pr-build] [38] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/38.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=38

seldondev · 2020-04-14T11:25:07Z

Tue Apr 14 11:25:06 UTC 2020
The logs for [lint] [39] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1668/39.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1668 --build=39

axsaucedo added 2 commits April 6, 2020 14:10

Updated operator constants

05ce123

Updated python client to existing changes of explainer

a084dcc

seldondev added the do-not-merge/work-in-progress label Apr 6, 2020

seldondev added the size/S label Apr 6, 2020

axsaucedo added 2 commits April 6, 2020 20:18

Updated operator to have aligned requirements on path

d2123cd

Added explainer test

ea77210

seldondev added size/M and removed size/S labels Apr 6, 2020

axsaucedo added 2 commits April 6, 2020 20:52

Merge remote-tracking branch 'upstream/master' into 1626_simple_expla…

c478c83

…iner_gateway_fix

fixed explainer typo

360cbf9

fixed explainer typo

fcb2115

Reverted addresses

5517a89

seldondev added the size/XL label Apr 8, 2020

axsaucedo changed the title ~~WIP: Explainer Gateway Fix for Istio, Ambassador and Python Client~~ Explainer Gateway Fix for Istio, Ambassador and Python Client Apr 8, 2020

seldondev removed the do-not-merge/work-in-progress label Apr 8, 2020

axsaucedo requested review from ukclivecox and adriangonz April 8, 2020 17:58

Updated python tests

bdb05cf

Updated python tests

8d9eed1

adriangonz reviewed Apr 9, 2020

View reviewed changes

Updated comment

b4b0bd5

seldondev added the approved label Apr 11, 2020

Merge remote-tracking branch 'upstream/master' into 1626_simple_expla…

d66dd08

…iner_gateway_fix

axsaucedo merged commit a42e8b3 into SeldonIO:master Apr 14, 2020

Explainer Gateway Fix for Istio, Ambassador and Python Client #1668

Explainer Gateway Fix for Istio, Ambassador and Python Client #1668

Conversation

axsaucedo commented Apr 6, 2020

axsaucedo commented Apr 6, 2020

seldondev commented Apr 6, 2020

seldondev commented Apr 6, 2020

seldondev commented Apr 6, 2020

axsaucedo commented Apr 6, 2020

seldondev commented Apr 6, 2020

seldondev commented Apr 6, 2020

seldondev commented Apr 6, 2020

axsaucedo commented Apr 6, 2020

seldondev commented Apr 6, 2020

seldondev commented Apr 6, 2020

seldondev commented Apr 6, 2020

axsaucedo commented Apr 6, 2020

seldondev commented Apr 6, 2020

seldondev commented Apr 6, 2020

seldondev commented Apr 6, 2020

axsaucedo commented Apr 6, 2020

seldondev commented Apr 6, 2020

seldondev commented Apr 8, 2020

seldondev commented Apr 8, 2020

seldondev commented Apr 9, 2020

seldondev commented Apr 9, 2020

seldondev commented Apr 9, 2020

seldondev commented Apr 9, 2020

adriangonz left a comment

Choose a reason for hiding this comment

adriangonz Apr 9, 2020

Choose a reason for hiding this comment

axsaucedo Apr 9, 2020

Choose a reason for hiding this comment

ukclivecox Apr 11, 2020

Choose a reason for hiding this comment

ukclivecox Apr 11, 2020

Choose a reason for hiding this comment

adriangonz Apr 9, 2020

Choose a reason for hiding this comment

axsaucedo Apr 9, 2020

Choose a reason for hiding this comment

adriangonz Apr 9, 2020

Choose a reason for hiding this comment

seldondev commented Apr 9, 2020

seldondev commented Apr 9, 2020

ukclivecox commented Apr 11, 2020

seldondev commented Apr 11, 2020

ukclivecox commented Apr 11, 2020

seldondev commented Apr 11, 2020

axsaucedo commented Apr 14, 2020

seldondev commented Apr 14, 2020

seldondev commented Apr 14, 2020

seldondev commented Apr 14, 2020

seldondev commented Apr 14, 2020

seldondev commented Apr 14, 2020