Allow non-model specific predict for Tensorflow protocol

[ukclivecox]

Fixes #1611

• Allows /v1/models/:predict
• Fixes error payload handling
• Adds tests and updates docs

[seldondev]

Sun Apr 12 10:00:15 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1684/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1684 --build=2

[seldondev]

Sun Apr 12 10:00:19 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1684/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1684 --build=1

[ryandawsonuk]

Just checking I've understood the change at https://github.com/SeldonIO/seldon-core/pull/1684/files#diff-a047655e38112373418dfdc7e8b71227R292 correctly. It means the model_name parameter will be optional? So if it's not set then you can still make a request to the graph-level endpoint by hitting /v1/models/:predict

[ukclivecox]

Just checking I've understood the change at https://github.com/SeldonIO/seldon-core/pull/1684/files#diff-a047655e38112373418dfdc7e8b71227R292 correctly. It means the model_name parameter will be optional? So if it's not set then you can still make a request to the graph-level endpoint by hitting /v1/models/:predict

Yes the model_name is needed just for Seldon protocol as it needs to run the tensorflow proxy server and in that it needs to know the model_name. For tensorflow protocol the name of the graph component will need to match the model loaded as that will be used.

[ryandawsonuk]

/lgtm
/approve

[seldondev]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ryandawsonuk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[seldondev]

Tue Apr 14 08:33:32 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1684/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1684 --build=4

[seldondev]

Tue Apr 14 08:33:39 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1684/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1684 --build=3

[seldondev]

failed to trigger Pull Request pipeline

• failed to create agent
• failed to calculate in repo config
• failed to load trigger config for repository SeldonIO/seldon-core for ref 7de281f
• failed to find any lighthouse configuration files in repo SeldonIO/seldon-core at sha 7de281f
• failed to process repo SeldonIO/seldon-core refref 7de281f
• failed to list files in directory /var/tmp/gitrepo660600678/.lighthouse
• open /var/tmp/gitrepo660600678/.lighthouse
• no such file or directory