Set idletimeout

[andrewshaoyu]

Fixes #1797

[seldondev]

Hi @andrewshaoyu. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ukclivecox]

/ok-to-test
/test integration

[seldondev]

Wed May 6 10:37:45 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1800/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1800 --build=1

[seldondev]

Wed May 6 10:37:57 UTC 2020
The logs for [integration] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1800/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1800 --build=2

[seldondev]

Wed May 6 10:37:58 UTC 2020
The logs for [lint] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1800/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1800 --build=3

[ukclivecox]

Is it worth making the core value configurable?

[andrewshaoyu]

it need to be configurable. i have a idea, set the idletimeout in seldon-operator's config, operator create the executor with the idletimeout ,and also make destinationrule with the idletimeout. the default value will be 60s and 65s?
i will update the pr

[ukclivecox]

@andrewshaoyu any update on this?

[ukclivecox]

@andrewshaoyu any update?

[andrewshaoyu]

sorry. I am too busy. i find new version executor remove the idle timeout. Make it configurable is important.

[ukclivecox]

/test notebooks

[seldondev]

Thu Jul 16 09:42:21 UTC 2020
The logs for [notebooks] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1800/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1800 --build=4

[ukclivecox]

/test notebooks

[ukclivecox]

/approve

[seldondev]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cliveseldon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[seldondev]

Mon Jul 20 11:07:35 UTC 2020
The logs for [notebooks] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1800/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1800 --build=5

[seldondev]

STARTING TEST [ lint # 7 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1800/7.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-1800 --build=7

[seldondev]

STARTING TEST [ pr-build # 6 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1800/6.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-1800 --build=6

[seldondev]

SUCCESS [lint # 7] TEST PASSED ✅

Well done! 😎

[seldondev]

SUCCESS [pr-build # 6] TEST PASSED ✅

Well done! 😎