Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add istio retries to docs #1842

Merged
merged 1 commit into from
May 28, 2020
Merged

Add istio retries to docs #1842

merged 1 commit into from
May 28, 2020

Conversation

ukclivecox
Copy link
Contributor

Fixes #1707

@ukclivecox ukclivecox requested a review from glindsell May 18, 2020 14:18
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: cliveseldon

If they are not already assigned, you can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Mon May 18 14:19:43 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1842/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1842 --build=2

@seldondev
Copy link
Collaborator

Mon May 18 14:19:49 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1842/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1842 --build=1

@axsaucedo
Copy link
Contributor

/test this

@seldondev
Copy link
Collaborator

Tue May 19 16:46:21 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1842/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1842 --build=3

@ukclivecox
Copy link
Contributor Author

/test this


```
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
name: seldon-gateway
naemspace: istio-system
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: typo

@seldondev
Copy link
Collaborator

Thu May 21 10:48:05 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1842/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1842 --build=4

@ukclivecox ukclivecox merged commit e504bf4 into SeldonIO:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs for istio annotations
3 participants