Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attach serviceAccountName to prepackaged deployment spec #1866

Merged

Conversation

enissay14
Copy link
Contributor

@enissay14 enissay14 commented May 22, 2020

Fixes #1865

Added `serviceAccountName` at the pod level to enable EKS fine-grained IAM roles.

@seldondev
Copy link
Collaborator

Hi @enissay14. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enissay14
Copy link
Contributor Author

/assign @RafalSkolasinski

@seldondev
Copy link
Collaborator

@Jeffwan: changing LGTM is restricted to assignees, and only SeldonIO/seldon-core repo collaborators may be assigned issues.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@seldondev
Copy link
Collaborator

@Jeffwan: changing LGTM is restricted to assignees, and only SeldonIO/seldon-core repo collaborators may be assigned issues.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan
Copy link

Jeffwan commented May 27, 2020

need to rebase upstream changes

@ukclivecox ukclivecox requested a review from ryandawsonuk May 28, 2020 08:35
@RafalSkolasinski RafalSkolasinski removed their assignment Jun 3, 2020
@ukclivecox
Copy link
Contributor

@enissay14 Any update on this and can you rebase?

Copy link
Contributor

@ryandawsonuk ryandawsonuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo
Copy link
Contributor

/ok-to-test

@seldondev
Copy link
Collaborator

Wed Jul 15 13:13:30 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1866/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1866 --build=1

@seldondev
Copy link
Collaborator

Wed Jul 15 13:14:17 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1866/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1866 --build=2

@axsaucedo axsaucedo merged commit 65c884f into SeldonIO:master Jul 15, 2020
@seldondev
Copy link
Collaborator

failed to trigger Pull Request pipeline

  • failed to create agent
  • failed to calculate in repo config
  • failed to load trigger config for repository SeldonIO/seldon-core for ref 0adff10
  • failed to find any lighthouse configuration files in repo SeldonIO/seldon-core at sha 0adff10
  • failed to process repo SeldonIO/seldon-core refref 0adff10
  • failed to list files in directory /var/tmp/gitrepo660600678/.lighthouse
  • open /var/tmp/gitrepo660600678/.lighthouse
  • no such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pass ServiceAccountName in predictor to prepackaged servers initContainer
7 participants