-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attach serviceAccountName to prepackaged deployment spec #1866
attach serviceAccountName to prepackaged deployment spec #1866
Conversation
Hi @enissay14. Thanks for your PR. I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @RafalSkolasinski |
@Jeffwan: changing LGTM is restricted to assignees, and only SeldonIO/seldon-core repo collaborators may be assigned issues. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Jeffwan: changing LGTM is restricted to assignees, and only SeldonIO/seldon-core repo collaborators may be assigned issues. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
need to rebase upstream changes |
@enissay14 Any update on this and can you rebase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan, ryandawsonuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Wed Jul 15 13:13:30 UTC 2020 impatient try |
Wed Jul 15 13:14:17 UTC 2020 impatient try |
failed to trigger Pull Request pipeline
|
Fixes #1865