Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix name of minio_setup notebook in links #1889

Merged
merged 1 commit into from
May 28, 2020
Merged

fix name of minio_setup notebook in links #1889

merged 1 commit into from
May 28, 2020

Conversation

RafalSkolasinski
Copy link
Contributor

A minor fix to the links. Somehow I wrote setup_minio instead of minio_setup

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@seldondev
Copy link
Collaborator

Thu May 28 13:20:30 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1889/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1889 --build=2

@seldondev
Copy link
Collaborator

Thu May 28 13:20:30 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1889/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1889 --build=1

@adriangonz
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 86ae2d5 into SeldonIO:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants