Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update prometheus-client requirement from <0.8.0,>=0.7.1 to >=0.7.1,<0.9.0 in /python #1903

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Update prometheus-client requirement from <0.8.0,>=0.7.1 to >=0.7.1,<0.9.0 in /python #1903

merged 1 commit into from
Jun 3, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

Updates the requirements on prometheus-client to permit the latest version.

Release notes

Sourced from prometheus-client's releases.

0.8.0 / 2020-05-25

[FEATURE] Added ASGI application (#512) [FEATURE] Add support for parsing timestamps in Prometheus exposition format. (#483) [FEATURE] Add target_info to registries (#453) [ENHANCEMENT] Handle empty and slashes in label values for pushgateway (#547 #442) [ENHANCEMENT] Various updates for latest OpenMetrics draft spec (#434 #445 #538 #460 #496) [ENHANCEMENT] Add HELP output for auto-created metrics (#471) [ENHANCEMENT] Use mmap.PAGESIZE constant as value for first read. (#505) [ENHANCEMENT] Add __repr__ method to metric objects, make them debug friendly. (#481) [ENHANCEMENT] Add observability check to metrics (#455 #520) [BUGFIX] Fix urlparse in python >= 3.7.6 (#497) [BUGFIX] Cleaning up name before appending unit on name (#543) [BUGFIX] Allow for OSError on Google App Engine (#448)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview
Update prometheus-client requirement in /python
dfee921 
Updates the requirements on [prometheus-client](https://github.com/prometheus/client_python) to permit the latest version.
- [Release notes](https://github.com/prometheus/client_python/releases)
- [Commits](prometheus/client_python@v0.7.1...v0.8.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file Python labels Jun 1, 2020
@dependabot-preview dependabot-preview bot requested a review from adriangonz June 1, 2020 09:19
@seldondev
Copy link
Collaborator

Hi @dependabot-preview[bot]. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adriangonz
Copy link
Contributor

/ok-to-test
/test integration

@adriangonz
Copy link
Contributor

@RafalSkolasinski do you see any potential issue upgrading to prometheus-client v0.8.x?

@seldondev
Copy link
Collaborator

Mon Jun 1 10:11:27 UTC 2020
The logs for [integration] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1903/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1903 --build=2

@seldondev
Copy link
Collaborator

Mon Jun 1 10:11:32 UTC 2020
The logs for [lint] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1903/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1903 --build=3

@seldondev
Copy link
Collaborator

Mon Jun 1 10:11:34 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1903/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1903 --build=1

@RafalSkolasinski
Copy link
Contributor

@RafalSkolasinski do you see any potential issue upgrading to prometheus-client v0.8.x?

If it will pass tests then I don't see any problems.
I think I only use it to craft the proper content for the endpoint so as long as tests will check that it is the same we are all good!

@adriangonz
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Tue Jun 2 08:23:19 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1903/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1903 --build=4

@RafalSkolasinski
Copy link
Contributor

Error in the CI

make[1]: Leaving directory '/workspace/source/servers/xgboostserver'
cd ../../servers/mlflowserver && make kind_load
make[1]: Entering directory '/workspace/source/servers/mlflowserver'
s2i build \
	-E environment_rest \
	./mlflowserver \
	seldonio/seldon-core-s2i-python37-ubi8:1.1.1-rc \
	seldonio/mlflowserver_rest:1.1.1-rc
ERROR: Error writing header for "scripts": io: read/write on closed pipe
ERROR: Error writing tar: io: read/write on closed pipe
Build failed
ERROR: An error occurred: context deadline exceeded
make[1]: Leaving directory '/workspace/source/servers/mlflowserver'
make[1]: *** [Makefile:8: build_rest] Error 1
make: *** [Makefile:29: kind_build_prepackaged] Error 2
Kind build has errors
kind delete cluster
Deleting cluster "kind" ...

Seems similar to something observed by @glindsell recently.

@RafalSkolasinski
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Tue Jun 2 10:13:14 UTC 2020
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1903/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1903 --build=5

@adriangonz
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Tue Jun 2 12:53:23 UTC 2020
The logs for [integration] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1903/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1903 --build=6

@adriangonz
Copy link
Contributor

/approve

Seems good now @RafalSkolasinski!

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Wed Jun 3 10:43:15 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1903/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1903 --build=8

@seldondev
Copy link
Collaborator

Wed Jun 3 10:43:23 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1903/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1903 --build=7

@seldondev seldondev merged commit de2dce0 into master Jun 3, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/pip/python/prometheus-client-gte-0.7.1-and-lt-0.9.0 branch June 3, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangonz adriangonz Awaiting requested review from adriangonz

Assignees
No one assigned
Labels
approved dependencies Pull requests that update a dependency file ok-to-test Python size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seldondev @adriangonz @RafalSkolasinski