Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the loop length from parmeters count #1908

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

abechen
Copy link
Contributor

@abechen abechen commented Jun 2, 2020

Fixed error when using parameters in deployment yaml.

When I set the following parameters:

predictors:
    - name: sample-graph
      graph:
        name: image-transformer-input
        type: TRANSFORMER
        endpoint:
          type: REST
        parameters:
        - name: env
          value: dev
          type: STRING
        children: []

The parameters in yaml would convert to json format:

[{"name":"env", "value":"dev", "type":"STRING"}]

When using seq_along, it would return 1 2 3
But in this case, I expect to return 1, because the json string just have 1 row not 3 rows.

> library(jsonlite)
> params <- '[{"name":"env", "value":"dev", "type":"STRING"}]'
> j = fromJSON(params)
> seq_along(j)
[1] 1 2 3

@seldondev
Copy link
Collaborator

Hi @abechen. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ukclivecox
Copy link
Contributor

Thanks!

@ukclivecox
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox ukclivecox merged commit ff72743 into SeldonIO:master Jun 2, 2020
@abechen abechen deleted the bugfix/extract-parmeters-error branch June 11, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants