add v1 metadata format that describes SeldonMessage more accurately #1911

RafalSkolasinski · 2020-06-03T16:49:50Z

extend metadata to cover seldon message

closes #1933

review-notebook-app · 2020-06-03T16:49:56Z

Check out this pull request on

Review Jupyter notebook visual diffs & provide feedback on notebooks.

Powered by ReviewNB

seldondev · 2020-06-03T16:51:30Z

Wed Jun 3 16:51:28 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=2

seldondev · 2020-06-03T16:51:30Z

Wed Jun 3 16:51:29 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=1

seldondev · 2020-06-04T16:00:47Z

Thu Jun 4 16:00:46 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=3

seldondev · 2020-06-04T16:00:51Z

Thu Jun 4 16:00:50 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=4

seldondev · 2020-06-05T11:13:37Z

Fri Jun 5 11:13:36 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=5

seldondev · 2020-06-05T11:13:39Z

Fri Jun 5 11:13:38 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=6

seldondev · 2020-06-05T11:19:17Z

Fri Jun 5 11:19:16 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=8

seldondev · 2020-06-05T11:19:36Z

Fri Jun 5 11:19:35 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=7

seldondev · 2020-06-05T11:26:24Z

Fri Jun 5 11:26:22 UTC 2020
The logs for [lint] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=10

seldondev · 2020-06-05T11:27:22Z

Fri Jun 5 11:27:22 UTC 2020
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=9

seldondev · 2020-06-05T11:27:39Z

Fri Jun 5 11:27:38 UTC 2020
The logs for [lint] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=12

seldondev · 2020-06-05T11:29:16Z

Fri Jun 5 11:29:15 UTC 2020
The logs for [pr-build] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=11

seldondev · 2020-06-05T11:32:46Z

Fri Jun 5 11:32:45 UTC 2020
The logs for [pr-build] [15] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/15.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=15

seldondev · 2020-06-05T11:33:23Z

Fri Jun 5 11:33:22 UTC 2020
The logs for [lint] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=14

seldondev · 2020-06-05T14:22:35Z

Fri Jun 5 14:22:34 UTC 2020
The logs for [pr-build] [16] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/16.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=16

seldondev · 2020-06-05T14:23:57Z

Fri Jun 5 14:23:56 UTC 2020
The logs for [lint] [17] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/17.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=17

seldondev · 2020-06-05T15:23:10Z

Fri Jun 5 15:23:08 UTC 2020
The logs for [lint] [19] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/19.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=19

seldondev · 2020-06-05T15:23:13Z

Fri Jun 5 15:23:12 UTC 2020
The logs for [pr-build] [18] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/18.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=18

seldondev · 2020-06-05T16:07:21Z

Fri Jun 5 16:07:18 UTC 2020
The logs for [pr-build] [20] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/20.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=20

seldondev · 2020-06-05T16:08:31Z

Fri Jun 5 16:08:30 UTC 2020
The logs for [lint] [21] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/21.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=21

seldondev · 2020-06-10T16:02:44Z

Wed Jun 10 16:02:43 UTC 2020
The logs for [pr-build] [22] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/22.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=22

RafalSkolasinski · 2020-06-11T10:44:49Z

/test notebooks

seldondev · 2020-06-11T10:47:13Z

Thu Jun 11 10:47:11 UTC 2020
The logs for [notebooks] [31] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/31.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=31

axsaucedo · 2020-06-11T12:00:12Z

/approve

seldondev · 2020-06-11T12:00:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [axsaucedo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

RafalSkolasinski · 2020-06-11T13:27:13Z

Afraid failing tests are related to #1934.
WIll wait once that one is merged and rebase.

RafalSkolasinski · 2020-06-11T14:28:07Z

/test integration
/test notebooks

seldondev · 2020-06-11T14:29:08Z

Thu Jun 11 14:29:07 UTC 2020
The logs for [pr-build] [32] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/32.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=32

seldondev · 2020-06-11T14:30:57Z

Thu Jun 11 14:30:56 UTC 2020
The logs for [integration] [35] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/35.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=35

seldondev · 2020-06-11T14:31:10Z

Thu Jun 11 14:31:10 UTC 2020
The logs for [notebooks] [34] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/34.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=34

seldondev · 2020-06-11T14:32:06Z

Thu Jun 11 14:32:05 UTC 2020
The logs for [lint] [33] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/33.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=33

RafalSkolasinski · 2020-06-11T16:42:28Z

Fixed few missed seldon-custom - > seldon adjustments.
Need to relaunched tests.

/test notebooks
/test integration

seldondev · 2020-06-11T16:43:57Z

Thu Jun 11 16:43:56 UTC 2020
The logs for [pr-build] [36] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/36.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=36

seldondev · 2020-06-11T16:43:57Z

Thu Jun 11 16:43:54 UTC 2020
The logs for [lint] [37] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/37.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=37

seldondev · 2020-06-11T16:45:52Z

Thu Jun 11 16:45:49 UTC 2020
The logs for [notebooks] [38] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/38.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=38

seldondev · 2020-06-11T16:46:07Z

Thu Jun 11 16:46:04 UTC 2020
The logs for [integration] [39] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/39.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=39

RafalSkolasinski · 2020-06-11T19:03:53Z

hmm... integration test fail on installing ambassador:

helm repo update
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "jaegertracing" chart repository
...Successfully got an update from the "seldonio" chart repository
...Successfully got an update from the "stable" chart repository
Update Complete. ⎈ Happy Helming!⎈ 
helm install ambassador \
	stable/ambassador \
	-f ../resources/ambassador_values.yaml \
	--set crds.keep=false \
	--namespace seldon \
	--set replicaCount=1 \
	--wait
WARNING: This chart is deprecated
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
Error: timed out waiting for the condition
make: *** [Makefile:50: install_ambassador] Error 1
Kind setup returned errors
kind delete cluster
Deleting cluster "kind" ...

/retest

seldondev · 2020-06-11T19:05:08Z

Thu Jun 11 19:05:04 UTC 2020
The logs for [integration] [40] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/40.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=40

RafalSkolasinski · 2020-06-11T20:51:15Z

/retest notebooks

RafalSkolasinski · 2020-06-12T08:43:34Z

/retest

seldondev · 2020-06-12T08:45:54Z

Fri Jun 12 08:45:53 UTC 2020
The logs for [notebooks] [41] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/41.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=41

RafalSkolasinski · 2020-06-12T09:51:58Z

@axsaucedo I am running notebook tests locally to verify if there are no blocking problems.
I hope it is only some CI issues.

seldondev · 2020-06-12T11:19:53Z

@RafalSkolasinski: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
notebooks	`f10d22c`	link	`/test notebooks`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

RafalSkolasinski · 2020-06-12T12:30:49Z

Local tests shows that all notebooks passes except these two:

test_notebooks.py::TestNotebooks::test_helm_examples
test_notebooks.py::TestNotebooks::test_istio_examples

that gonna be fix by #1940

@axsaucedo I suggest we merge it ;)

seldondev · 2020-07-06T11:39:52Z

Mon Jul 6 11:39:51 UTC 2020
The logs for [pr-build] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1911/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1911 --build=13

RafalSkolasinski marked this pull request as draft June 3, 2020 16:49

seldondev requested review from adriangonz and glindsell June 3, 2020 16:50

seldondev added the size/XL label Jun 3, 2020

ukclivecox changed the title ~~wip~~ WIP: extend metadata to cover seldon message using openApi schemas Jun 4, 2020

seldondev added do-not-merge/work-in-progress size/XXL and removed size/XL labels Jun 4, 2020

RafalSkolasinski mentioned this pull request Jun 11, 2020

extend metadata to cover seldon message #1933

Closed

seldondev removed the do-not-merge/work-in-progress label Jun 11, 2020

seldondev added the approved label Jun 11, 2020

introduce v1 metadata format

6acdcaa

code review fixes

f10d22c

RafalSkolasinski merged commit 8eba866 into SeldonIO:master Jun 12, 2020

add v1 metadata format that describes SeldonMessage more accurately #1911

add v1 metadata format that describes SeldonMessage more accurately #1911

Conversation

RafalSkolasinski commented Jun 3, 2020 • edited Loading

review-notebook-app bot commented Jun 3, 2020

seldondev commented Jun 3, 2020

seldondev commented Jun 3, 2020

seldondev commented Jun 4, 2020

seldondev commented Jun 4, 2020

seldondev commented Jun 5, 2020

seldondev commented Jun 5, 2020

seldondev commented Jun 5, 2020

seldondev commented Jun 5, 2020

seldondev commented Jun 5, 2020

seldondev commented Jun 5, 2020

seldondev commented Jun 5, 2020

seldondev commented Jun 5, 2020

seldondev commented Jun 5, 2020

seldondev commented Jun 5, 2020

seldondev commented Jun 5, 2020

seldondev commented Jun 5, 2020

seldondev commented Jun 5, 2020

seldondev commented Jun 5, 2020

seldondev commented Jun 5, 2020

seldondev commented Jun 5, 2020

seldondev commented Jun 10, 2020

RafalSkolasinski commented Jun 11, 2020

seldondev commented Jun 11, 2020

axsaucedo commented Jun 11, 2020

seldondev commented Jun 11, 2020

RafalSkolasinski commented Jun 11, 2020

RafalSkolasinski commented Jun 11, 2020

seldondev commented Jun 11, 2020

seldondev commented Jun 11, 2020

seldondev commented Jun 11, 2020

seldondev commented Jun 11, 2020

RafalSkolasinski commented Jun 11, 2020

seldondev commented Jun 11, 2020

seldondev commented Jun 11, 2020

seldondev commented Jun 11, 2020

seldondev commented Jun 11, 2020

RafalSkolasinski commented Jun 11, 2020

seldondev commented Jun 11, 2020

RafalSkolasinski commented Jun 11, 2020

RafalSkolasinski commented Jun 12, 2020

seldondev commented Jun 12, 2020

RafalSkolasinski commented Jun 12, 2020

seldondev commented Jun 12, 2020

RafalSkolasinski commented Jun 12, 2020 • edited Loading

seldondev commented Jul 6, 2020

RafalSkolasinski commented Jun 3, 2020 •

edited

Loading

RafalSkolasinski commented Jun 12, 2020 •

edited

Loading