-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update licenses #1954
Update licenses #1954
Conversation
Mon Jun 15 17:51:34 UTC 2020 impatient try |
Mon Jun 15 17:51:32 UTC 2020 impatient try |
/retest |
Tue Jun 16 10:12:25 UTC 2020 impatient try |
Tue Jun 16 10:16:41 UTC 2020 impatient try |
Tue Jun 16 10:16:45 UTC 2020 impatient try |
NYTimes/gziphandler | ||
PuerkitoBio/purell | ||
PuerkitoBio/urlesc | ||
Shopify/sarama |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is sarama
also included? Wasn't that part of the Kafka PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Due to Zipkin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it wasn't part of the kafka PR yet.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriangonz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tue Jun 16 16:55:39 UTC 2020 impatient try |
Tue Jun 16 16:55:40 UTC 2020 impatient try |
@cliveseldon: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Fixes #1947