Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing minor typo on istio docs #1957

Merged
merged 1 commit into from
Jun 16, 2020
Merged

fixing minor typo on istio docs #1957

merged 1 commit into from
Jun 16, 2020

Conversation

mtarng
Copy link
Contributor

@mtarng mtarng commented Jun 16, 2020

No description provided.

@seldondev
Copy link
Collaborator

Hi @mtarng. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ukclivecox
Copy link
Contributor

Thanks @mtarng

@ukclivecox
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox
Copy link
Contributor

/ok-to-test

@seldondev
Copy link
Collaborator

Tue Jun 16 06:56:51 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1957/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1957 --build=2

@seldondev
Copy link
Collaborator

Tue Jun 16 06:56:59 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1957/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1957 --build=1

@seldondev seldondev merged commit bd6c144 into SeldonIO:master Jun 16, 2020
@mtarng mtarng deleted the patch-1 branch June 16, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants