Fix annotations and labels in Helm chart #1967
Conversation
|
Wed Jun 17 11:33:43 UTC 2020 impatient try |
|
Wed Jun 17 11:33:53 UTC 2020 impatient try |
|
/test integration |
|
Wed Jun 17 11:36:28 UTC 2020 impatient try |
|
Wed Jun 17 11:36:34 UTC 2020 impatient try |
| @@ -6,15 +6,15 @@ | |||
| "namespace": "{{ .Release.Namespace }}", | |||
| "labels": { | |||
| {{- range $name, $val := .Values.labels }} | |||
| "{{ $name }}": "{{ $val }}" | |||
| "{{ $name }}": "{{ $val }}", | |||
There was a problem hiding this comment.
Looks good, however with javascript wouldn't you still have an issue if you have a trailing slash? I have seen that with arrays you can use {{if ne $index 0}},{{end}} but in this case you only have name,val so not sure whether it'd be the case. Did it not error out in your case with the extra comma at the end?
There was a problem hiding this comment.
Helm usually reads and writes YAMLs, and it seems that the YAML parser is happy with trailing commas.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@adriangonz: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
failed to trigger Pull Request pipeline
|
Changelog
seldon-single-modelchart