Lint licenses #1995

adriangonz · 2020-06-22T12:45:03Z

Fixes #1932

Changelog

In Python server, rename make run_lint and make run_linter_check to make fmt and make lint.
Add target make lint to operator and executor (and add them to JX lint pipeline).
Across packages, make sure that make lint checks if licenses have changed.

Notes

On Python, lint seems to fail because the output of pip-licenses depends on the environment. Therefore, JX is generating a slightly different license doc. I've opened up an issue on pip-licenses reporting this: raimon49/pip-licenses#69

~~In the meantime, we can generate the output locally so that it matches what gets generated in the JX cluster.~~

The issue with pip-licenses has now been resolved.

adriangonz · 2020-06-22T12:45:15Z

/cc @axsaucedo @cliveseldon @RafalSkolasinski

seldondev · 2020-06-22T12:46:27Z

Mon Jun 22 12:46:26 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1995/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1995 --build=2

seldondev · 2020-06-22T12:47:59Z

Mon Jun 22 12:47:57 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1995/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1995 --build=1

seldondev · 2020-06-22T15:27:06Z

Mon Jun 22 15:27:05 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1995/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1995 --build=4

seldondev · 2020-06-22T15:28:38Z

Mon Jun 22 15:28:37 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1995/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1995 --build=3

adriangonz · 2020-06-23T08:14:22Z

/test this

seldondev · 2020-06-23T08:16:11Z

Tue Jun 23 08:16:10 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1995/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1995 --build=5

seldondev · 2020-06-23T08:45:51Z

Tue Jun 23 08:45:50 UTC 2020
The logs for [lint] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1995/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1995 --build=7

seldondev · 2020-06-23T08:45:59Z

Tue Jun 23 08:45:57 UTC 2020
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1995/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1995 --build=6

seldondev · 2020-06-23T09:11:05Z

Tue Jun 23 09:11:04 UTC 2020
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1995/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1995 --build=9

seldondev · 2020-06-23T09:11:10Z

Tue Jun 23 09:11:08 UTC 2020
The logs for [pr-build] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1995/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1995 --build=8

seldondev · 2020-06-23T15:57:53Z

Tue Jun 23 15:57:52 UTC 2020
The logs for [pr-build] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1995/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1995 --build=10

seldondev · 2020-06-23T15:57:58Z

Tue Jun 23 15:57:57 UTC 2020
The logs for [lint] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1995/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1995 --build=11

seldondev · 2020-06-23T16:12:47Z

Tue Jun 23 16:12:46 UTC 2020
The logs for [lint] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1995/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1995 --build=13

seldondev · 2020-06-23T16:13:46Z

Tue Jun 23 16:13:45 UTC 2020
The logs for [pr-build] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1995/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1995 --build=12

seldondev · 2020-06-25T09:33:04Z

Thu Jun 25 09:33:03 UTC 2020
The logs for [lint] [15] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1995/15.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1995 --build=15

seldondev · 2020-06-25T09:33:17Z

Thu Jun 25 09:33:16 UTC 2020
The logs for [pr-build] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1995/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1995 --build=14

RafalSkolasinski · 2020-06-29T08:47:26Z

\lgtm

RafalSkolasinski · 2020-06-29T08:47:32Z

/lgtm

seldondev · 2020-06-29T08:55:46Z

Mon Jun 29 08:55:44 UTC 2020
The logs for [lint] [17] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1995/17.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1995 --build=17

seldondev · 2020-07-07T15:47:42Z

Tue Jul 7 15:47:41 UTC 2020
The logs for [lint] [25] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1995/25.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1995 --build=25

seldondev · 2020-07-07T15:47:46Z

Tue Jul 7 15:47:45 UTC 2020
The logs for [pr-build] [24] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1995/24.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1995 --build=24

seldondev · 2020-07-07T15:50:36Z

Tue Jul 7 15:50:35 UTC 2020
The logs for [pr-build] [26] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1995/26.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1995 --build=26

seldondev · 2020-07-07T15:50:37Z

Tue Jul 7 15:50:36 UTC 2020
The logs for [lint] [27] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1995/27.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1995 --build=27

adriangonz · 2020-07-08T08:39:14Z

/unhold

adriangonz · 2020-07-08T08:39:46Z

/hold cancel

seldondev · 2020-07-08T08:41:35Z

Wed Jul 8 08:41:34 UTC 2020
The logs for [pr-build] [28] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1995/28.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1995 --build=28

seldondev · 2020-07-08T08:41:43Z

Wed Jul 8 08:41:39 UTC 2020
The logs for [lint] [29] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1995/29.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1995 --build=29

seldondev · 2021-05-13T06:37:42Z

failed to trigger Pull Request pipeline

failed to create agent
failed to calculate in repo config
failed to load trigger config for repository SeldonIO/seldon-core for ref 924ea12
failed to find any lighthouse configuration files in repo SeldonIO/seldon-core at sha 924ea12
failed to process repo SeldonIO/seldon-core refref 924ea12
failed to list files in directory /var/tmp/gitrepo660600678/.lighthouse
open /var/tmp/gitrepo660600678/.lighthouse
no such file or directory

seldondev requested review from axsaucedo, ukclivecox and RafalSkolasinski June 22, 2020 12:45

seldondev added the size/L label Jun 22, 2020

adriangonz force-pushed the lint-licenses branch from 16f6282 to c3590d4 Compare June 23, 2020 08:43

seldondev added size/XL and removed size/L labels Jun 23, 2020

seldondev assigned RafalSkolasinski Jun 29, 2020

seldondev added lgtm approved labels Jun 29, 2020

adriangonz marked this pull request as ready for review July 7, 2020 15:16

Adrian Gonzalez-Martin added 12 commits July 7, 2020 16:41

Rename targets and add changed licenses

9cdccaa

Use new name

4070964

Add lint target

c18ff8d

Add operator and executor to lint pipeline

c54f49d

Show license diff

063f492

Force Python 3

daafd0a

re-gen from CI

b5b5c10

Fix diff

61382ce

Re-gen licenses after updating pip-licenses

48ea7ab

Recreate licenses environment to fetch latest versions

6e257d9

Re-gen licenses with fresh environment

a1c2332

Remove auto-formatting

86f4c8e

adriangonz force-pushed the lint-licenses branch from 7645535 to 86f4c8e Compare July 7, 2020 15:45

seldondev added size/M and removed size/XL labels Jul 7, 2020

Use lint target

924ea12

seldondev removed the do-not-merge/hold label Jul 8, 2020

seldondev merged commit 3cc1b53 into SeldonIO:master Jul 8, 2020

adriangonz mentioned this pull request Jul 15, 2020

Fix Go license linting #2136

Merged

axsaucedo unassigned RafalSkolasinski May 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lint licenses #1995

Lint licenses #1995

adriangonz commented Jun 22, 2020 •

edited

Loading

adriangonz commented Jun 22, 2020

seldondev commented Jun 22, 2020

seldondev commented Jun 22, 2020

seldondev commented Jun 22, 2020

seldondev commented Jun 22, 2020

adriangonz commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 25, 2020

seldondev commented Jun 25, 2020

RafalSkolasinski commented Jun 29, 2020

RafalSkolasinski commented Jun 29, 2020

seldondev commented Jun 29, 2020

seldondev commented Jul 7, 2020

seldondev commented Jul 7, 2020

seldondev commented Jul 7, 2020

seldondev commented Jul 7, 2020

adriangonz commented Jul 8, 2020

adriangonz commented Jul 8, 2020

seldondev commented Jul 8, 2020

seldondev commented Jul 8, 2020

seldondev commented May 13, 2021

Lint licenses #1995

Lint licenses #1995

Conversation

adriangonz commented Jun 22, 2020 • edited Loading

Changelog

Notes

adriangonz commented Jun 22, 2020

seldondev commented Jun 22, 2020

seldondev commented Jun 22, 2020

seldondev commented Jun 22, 2020

seldondev commented Jun 22, 2020

adriangonz commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 25, 2020

seldondev commented Jun 25, 2020

RafalSkolasinski commented Jun 29, 2020

RafalSkolasinski commented Jun 29, 2020

seldondev commented Jun 29, 2020

seldondev commented Jul 7, 2020

seldondev commented Jul 7, 2020

seldondev commented Jul 7, 2020

seldondev commented Jul 7, 2020

adriangonz commented Jul 8, 2020

adriangonz commented Jul 8, 2020

seldondev commented Jul 8, 2020

seldondev commented Jul 8, 2020

seldondev commented May 13, 2021

adriangonz commented Jun 22, 2020 •

edited

Loading