Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump github.com/gorilla/mux from 1.7.3 to 1.7.4 in /executor #1997

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Bump github.com/gorilla/mux from 1.7.3 to 1.7.4 in /executor #1997

merged 1 commit into from
Jun 22, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps github.com/gorilla/mux from 1.7.3 to 1.7.4.

Release notes

Sourced from github.com/gorilla/mux's releases.

v1.7.4 addresses a number of performance improvements (#544), bugs (#509, #535), and documentation improvements.

CHANGELOG

Commits
  • 75dcda0 perf: reduce allocations in (*routeRegexp).getURLQuery (#544)
  • 49c0148 lint: Remove golint warning (#526)
  • 4de8a5a fix headers regexp test (#536)
  • 2854a05 Merge pull request #535 from fharding1/cors-subrouter-bug
  • 946b623 Fix the CORSMethodMiddleware bug with subrouters
  • f395758 Remove/cleanup request context helpers (#525)
  • ff4e71f Guess the scheme if r.URL.Scheme is unset (#474)
  • 884b5ff Added capacity to slice creation, when capacity is known (#516)
  • e1863a6 Modified http status codes, using constants provided by the http package (#514)
  • 9536e40 bugfix: subrouter custom methodNotAllowed handler returning 404 (#509) (#510)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview
Bump github.com/gorilla/mux from 1.7.3 to 1.7.4 in /executor
8be52a1 
Bumps [github.com/gorilla/mux](https://github.com/gorilla/mux) from 1.7.3 to 1.7.4.
- [Release notes](https://github.com/gorilla/mux/releases)
- [Commits](gorilla/mux@v1.7.3...v1.7.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jun 22, 2020
@dependabot-preview dependabot-preview bot requested a review from adriangonz June 22, 2020 13:23
@seldondev
Copy link
Collaborator

Hi @dependabot-preview[bot]. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adriangonz
Copy link
Contributor

/ok-to-test

@seldondev
Copy link
Collaborator

Mon Jun 22 14:58:36 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1997/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1997 --build=1

@seldondev
Copy link
Collaborator

Mon Jun 22 14:59:34 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1997/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1997 --build=2

@adriangonz
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Mon Jun 22 19:35:44 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1997/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1997 --build=8

@seldondev
Copy link
Collaborator

Mon Jun 22 19:35:57 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1997/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1997 --build=7

@seldondev seldondev merged commit f597ec4 into master Jun 22, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/go_modules/executor/github.com/gorilla/mux-1.7.4 branch June 22, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangonz adriangonz Awaiting requested review from adriangonz

Assignees
No one assigned
Labels
approved dependencies Pull requests that update a dependency file go Pull requests that update Go code ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seldondev @adriangonz