Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/golang/protobuf from 1.3.5 to 1.4.2 in /executor #1998

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jun 22, 2020

Bumps github.com/golang/protobuf from 1.3.5 to 1.4.2.

Release notes

Sourced from github.com/golang/protobuf's releases.

v1.4.2

Notable changes:

  • (#1131) all: upgrade to google.golang.org/protobuf@v1.23.0
  • (#1125) jsonpb: fix a confusing error message
  • (#1129) proto: make InternalMessageInfo functional

v1.4.1

Notable changes:

  • (#1114) all: upgrade to google.golang.org/protobuf@v1.22.0
  • (#1113) protoc-gen-go/grpc: make identical to v1.3.5

v1.4.0

Overview

This release of the github.com/golang/protobuf module introduces a number of significant changes relative to the previous minor release. In particular, this module is now implemented in terms of the new google.golang.org/protobuf module, which is the next major revision of Go bindings for protocol buffers. From this point onwards, most of the development effort for Go protobufs will be dedicated to the new module, with minimal changes being made to this module.

See the release notes for the new module for specific implementation details that may affect this release.

Backwards compatibility

This release maintains backwards compatibility with previous releases of this module. Any observable changes in behavior are to fix bugs, change unspecified behavior, or to make behavior more compliant with the protobuf specification. The compatibility document provides us the freedom to make changes in these areas.

Notable changes

Wire serialization

Wire serialization is now implemented in terms of the new proto package by calling out to the relevant functionality in that package (e.g., proto.Marshal and proto.Unmarshal). There should be no observable changes in behavior other what is mentioned elsewhere in the release notes (e.g., behavior around errors or nil values).

JSON and text serialization

The JSON and text format implementations have been ported to use protobuf reflection under the hood instead of relying on Go reflection. This provides flexibility as they can operate on any concrete message type that properly implements the new proto.Message interface.

The implementations do not use the new protojson or prototext packages in order to maintain a higher degree of backwards compatibility. Our analysis unfortunately showed us that too many tests rely on their output being stable by performing byte-for-byte comparisons. Even though the compatibility promise gives us the freedom to change the output, we have chosen not to do so for pragmatic reasons. The implementations are now functionally frozen (bugs and all) and will not receive future improvements. Users are encouraged to migrate to the protojson or prototext packages instead.

Commits
  • d04d7b1 all: upgrade to google.golang.org/protobuf@v1.23.0 (#1131)
  • 07c14f1 proto: make InternalMessageInfo functional (#1129)
  • 00998c7 jsonpb: fix a confusing error message (#1125)
  • 6c66de7 all: upgrade to google.golang.org/protobuf@v1.22.0 (#1114)
  • b5de78c all: minor documentation adjustments (#1112)
  • 8d9af28 protoc-gen-go/grpc: make grpc identical to v1.3.5 (#1113)
  • fa093f5 proto: fix stale deprecation documentation on registry functions (#1093)
  • 1b794fe all: upgrade to google.golang.org/protobuf@v1.21.0 (#1081)
  • e9dc0d7 all: update to wrap google.golang.org/protobuf
  • 3a3cefd all: use google.golang.org/protobuf/testing/protopack for tests (#1063)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jun 22, 2020
@dependabot-preview dependabot-preview bot requested a review from adriangonz June 22, 2020 13:23
@seldondev
Copy link
Collaborator

Hi @dependabot-preview[bot]. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adriangonz
Copy link
Contributor

/ok-to-test

@seldondev
Copy link
Collaborator

Mon Jun 22 14:57:27 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1998/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1998 --build=1

@seldondev
Copy link
Collaborator

Mon Jun 22 14:57:30 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1998/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1998 --build=2

@adriangonz
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

Mon Jun 22 19:53:51 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1998/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1998 --build=4

@dependabot-preview
Copy link
Contributor Author

Dependabot tried to update this pull request, but something went wrong. The most likely cause is #2003, which may be blocking Dependabot from updating your dependency files.

@adriangonz
Copy link
Contributor

/test this

@seldondev
Copy link
Collaborator

Tue Jun 23 08:16:50 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1998/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1998 --build=5

@adriangonz
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dependabot-preview dependabot-preview bot force-pushed the dependabot/go_modules/executor/github.com/golang/protobuf-1.4.2 branch from 3487fc5 to 5f8ee37 Compare June 23, 2020 08:31
@seldondev
Copy link
Collaborator

Tue Jun 23 08:33:53 UTC 2020
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1998/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1998 --build=6

@seldondev
Copy link
Collaborator

Tue Jun 23 08:33:55 UTC 2020
The logs for [lint] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1998/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1998 --build=7

Bumps [github.com/golang/protobuf](https://github.com/golang/protobuf) from 1.3.5 to 1.4.2.
- [Release notes](https://github.com/golang/protobuf/releases)
- [Commits](golang/protobuf@v1.3.5...v1.4.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/go_modules/executor/github.com/golang/protobuf-1.4.2 branch from 5f8ee37 to e375b0b Compare June 23, 2020 08:52
@seldondev
Copy link
Collaborator

Tue Jun 23 08:55:40 UTC 2020
The logs for [pr-build] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1998/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1998 --build=8

@seldondev
Copy link
Collaborator

Tue Jun 23 08:55:40 UTC 2020
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1998/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1998 --build=9

@seldondev seldondev merged commit 51e9153 into master Jun 23, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/go_modules/executor/github.com/golang/protobuf-1.4.2 branch June 23, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dependencies Pull requests that update a dependency file go Pull requests that update Go code ok-to-test size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants