SeldonMetadata and GRPC support #2005

RafalSkolasinski · 2020-06-23T14:39:20Z

Standardise SeldonMetadata further and add GRPC support

reopened: #1969

ToDo:

Add GRPC tests to Executor
Add proper integration test (not notebook involved)
Update docs

Added gRPC support to model metadata.

review-notebook-app · 2020-06-23T14:39:26Z

Check out this pull request on

Review Jupyter notebook visual diffs & provide feedback on notebooks.

Powered by ReviewNB

seldondev · 2020-06-23T14:43:07Z

Tue Jun 23 14:43:06 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=2

seldondev · 2020-06-23T14:43:16Z

Tue Jun 23 14:43:15 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=1

seldondev · 2020-06-23T14:44:52Z

Tue Jun 23 14:44:51 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=3

seldondev · 2020-06-23T14:46:50Z

Tue Jun 23 14:46:48 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=4

seldondev · 2020-06-23T14:49:15Z

Tue Jun 23 14:49:13 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=5

seldondev · 2020-06-23T14:49:26Z

Tue Jun 23 14:49:25 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=6

seldondev · 2020-06-24T15:09:09Z

Wed Jun 24 15:09:08 UTC 2020
The logs for [pr-build] [15] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/15.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=15

seldondev · 2020-06-24T15:09:10Z

Wed Jun 24 15:09:09 UTC 2020
The logs for [lint] [16] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/16.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=16

seldondev · 2020-06-24T16:31:59Z

Wed Jun 24 16:31:57 UTC 2020
The logs for [lint] [18] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/18.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=18

seldondev · 2020-06-24T16:33:23Z

Wed Jun 24 16:33:22 UTC 2020
The logs for [pr-build] [17] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/17.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=17

seldondev · 2020-06-27T10:51:50Z

Sat Jun 27 10:51:49 UTC 2020
The logs for [integration] [75] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/75.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=75

RafalSkolasinski · 2020-06-29T08:23:39Z

/retest

RafalSkolasinski · 2020-06-29T08:24:50Z

/test notebooks
/test integration

seldondev · 2020-06-29T08:25:22Z

Mon Jun 29 08:25:20 UTC 2020
The logs for [lint] [77] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/77.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=77

seldondev · 2020-06-29T08:25:44Z

Mon Jun 29 08:25:43 UTC 2020
The logs for [pr-build] [76] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/76.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=76

seldondev · 2020-06-29T08:27:53Z

Mon Jun 29 08:27:52 UTC 2020
The logs for [notebooks] [78] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/78.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=78

seldondev · 2020-06-29T08:28:13Z

Mon Jun 29 08:28:11 UTC 2020
The logs for [integration] [79] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/79.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=79

RafalSkolasinski · 2020-06-29T08:33:33Z

/retest

seldondev · 2020-06-29T08:36:02Z

Mon Jun 29 08:36:00 UTC 2020
The logs for [pr-build] [80] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/80.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=80

RafalSkolasinski · 2020-06-29T11:09:48Z

/retest

seldondev · 2020-06-29T11:11:25Z

Mon Jun 29 11:11:24 UTC 2020
The logs for [notebooks] [81] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/81.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=81

seldondev · 2020-06-29T11:12:39Z

Mon Jun 29 11:12:38 UTC 2020
The logs for [integration] [82] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/82.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=82

RafalSkolasinski · 2020-06-29T16:29:53Z

/test notebooks

seldondev · 2020-06-29T16:31:39Z

Mon Jun 29 16:31:38 UTC 2020
The logs for [notebooks] [83] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/83.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=83

RafalSkolasinski · 2020-06-30T11:30:56Z

/test notebooks

seldondev · 2020-06-30T11:31:10Z

Tue Jun 30 11:31:09 UTC 2020
The logs for [pr-build] [84] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/84.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=84

seldondev · 2020-06-30T11:31:32Z

Tue Jun 30 11:31:31 UTC 2020
The logs for [lint] [85] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/85.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=85

seldondev · 2020-06-30T11:32:38Z

Tue Jun 30 11:32:36 UTC 2020
The logs for [notebooks] [86] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/86.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=86

RafalSkolasinski · 2020-07-01T09:24:23Z

/test integration

seldondev · 2020-07-01T09:25:44Z

Wed Jul 1 09:25:43 UTC 2020
The logs for [integration] [87] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/87.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=87

RafalSkolasinski · 2020-07-02T09:24:35Z

Ready to merge! :)

ukclivecox · 2020-07-02T10:39:38Z

/approve

seldondev · 2020-07-02T10:39:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cliveseldon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

RafalSkolasinski · 2020-07-02T11:04:17Z

🚀

seldondev · 2020-07-06T11:39:11Z

Mon Jul 6 11:39:10 UTC 2020
The logs for [pr-build] [41] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2005/41.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2005 --build=41

seldondev added the size/XXL label Jun 23, 2020

RafalSkolasinski marked this pull request as draft June 23, 2020 14:48

seldondev added the do-not-merge/work-in-progress label Jun 23, 2020

RafalSkolasinski added 14 commits June 24, 2020 16:07

add protos

e9971c5

add python

20739a2

add go

e6a65e4

make inputs/outputs always array; adjust seldon schemas

f97909a

update proto

c4742b0

update code

1a10183

minor cleanup in executor

94fda34

yet another proto/schema update

d35d66a

adjust python tests and basic examples

a370851

remove notebook that should not go into PR

e60f500

remove ApiVersion from executor metadata code

e4c573e

refactor executor code

960ed6b

fix tests before making them proper

0bb5605

improve executor metadata tests

2cc573c

further test client cleanup

635ec11

add grpc server metadata tests

48c4078

RafalSkolasinski added 2 commits June 30, 2020 12:29

minor tweaks: remove redundant notebook, remove jq from example

84cab24

fix notebook server_examples to not fail on MLFlow server

d65b153

seldondev added the approved label Jul 2, 2020

ukclivecox removed the do-not-merge/work-in-progress label Jul 2, 2020

ukclivecox merged commit 2d0dc3e into SeldonIO:master Jul 2, 2020

SeldonMetadata and GRPC support #2005

SeldonMetadata and GRPC support #2005

Conversation

RafalSkolasinski commented Jun 23, 2020 • edited by adriangonz Loading

review-notebook-app bot commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 23, 2020

seldondev commented Jun 24, 2020

seldondev commented Jun 24, 2020

seldondev commented Jun 24, 2020

seldondev commented Jun 24, 2020

seldondev commented Jun 27, 2020

RafalSkolasinski commented Jun 29, 2020

RafalSkolasinski commented Jun 29, 2020

seldondev commented Jun 29, 2020

seldondev commented Jun 29, 2020

seldondev commented Jun 29, 2020

seldondev commented Jun 29, 2020

RafalSkolasinski commented Jun 29, 2020

seldondev commented Jun 29, 2020

RafalSkolasinski commented Jun 29, 2020

seldondev commented Jun 29, 2020

seldondev commented Jun 29, 2020

RafalSkolasinski commented Jun 29, 2020

seldondev commented Jun 29, 2020

RafalSkolasinski commented Jun 30, 2020

seldondev commented Jun 30, 2020

seldondev commented Jun 30, 2020

seldondev commented Jun 30, 2020

RafalSkolasinski commented Jul 1, 2020

seldondev commented Jul 1, 2020

RafalSkolasinski commented Jul 2, 2020

ukclivecox commented Jul 2, 2020

seldondev commented Jul 2, 2020

RafalSkolasinski commented Jul 2, 2020

seldondev commented Jul 6, 2020

RafalSkolasinski commented Jun 23, 2020 •

edited by adriangonz

Loading