Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first expand test for upgrade status #2018

Closed

Conversation

ryandawsonuk
Copy link
Contributor

@ryandawsonuk ryandawsonuk commented Jun 26, 2020

for #2017
Hoping to see this fail as this is expanding the check to catch failed sdeps during an operator upgrade. Should fail during upgrade of 1.1.0 to master

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ryandawsonuk

If they are not already assigned, you can assign the PR to them by writing /assign @ryandawsonuk in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Fri Jun 26 16:40:19 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2018/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2018 --build=2

@seldondev
Copy link
Collaborator

Fri Jun 26 16:40:35 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2018/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2018 --build=1

@ryandawsonuk
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Fri Jun 26 16:46:15 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2018/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2018 --build=3

@seldondev
Copy link
Collaborator

Fri Jun 26 16:46:16 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2018/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2018 --build=4

@seldondev
Copy link
Collaborator

@ryandawsonuk: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 0501f49 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ryandawsonuk
Copy link
Contributor Author

Well this is flawed due to #2019 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants