Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executor/deps update - straightforward dependencies update #2099

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Executor/deps update - straightforward dependencies update #2099

merged 1 commit into from
Jul 10, 2020

Conversation

RafalSkolasinski
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski commented Jul 9, 2020

Closes #2089.

Updated executor dependencies.

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Thu Jul 9 11:44:46 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2099/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2099 --build=2

@seldondev
Copy link
Collaborator

Thu Jul 9 11:45:06 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2099/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2099 --build=1

@seldondev
Copy link
Collaborator

Thu Jul 9 11:45:20 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2099/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2099 --build=3

@RafalSkolasinski
Copy link
Contributor Author

Failure on test_rolling_deployment[graph1.json-graph4.json-True-ambas]. Probably flakiness.
/test integration

@seldondev
Copy link
Collaborator

Thu Jul 9 12:29:31 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2099/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2099 --build=4

@axsaucedo
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

@RafalSkolasinski: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 5b452b4 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@seldondev
Copy link
Collaborator

Thu Jul 9 13:01:05 UTC 2020
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2099/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2099 --build=5

@axsaucedo
Copy link
Contributor

/test notebooks

@seldondev
Copy link
Collaborator

Thu Jul 9 13:41:56 UTC 2020
The logs for [notebooks] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2099/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2099 --build=6

@axsaucedo
Copy link
Contributor

Maybe it could make sense to wait for #2093 to be merged and then rebase to ensure all works correctly with the updated deps (that should be the case tho, but just to make sure)

@RafalSkolasinski
Copy link
Contributor Author

Sure, sound good. Though seems the changes are orthogonal.

On #2093 I wanted to base update of operator dep and k8s.io deps.

@axsaucedo
Copy link
Contributor

@RafalSkolasinski seems integration tests pass 👍

@RafalSkolasinski
Copy link
Contributor Author

Nice, momentum is good on this 🚀

@adriangonz
Copy link
Contributor

/test integration
/test notebooks

@seldondev
Copy link
Collaborator

Fri Jul 10 10:16:51 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2099/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2099 --build=7

@seldondev
Copy link
Collaborator

Fri Jul 10 10:16:54 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2099/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2099 --build=8

@seldondev
Copy link
Collaborator

Fri Jul 10 10:17:23 UTC 2020
The logs for [notebooks] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2099/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2099 --build=9

@seldondev
Copy link
Collaborator

Fri Jul 10 10:18:57 UTC 2020
The logs for [integration] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2099/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2099 --build=10

@axsaucedo
Copy link
Contributor

Both notebooks and integrations pass 🚀
Merging manually as it's not being reflected
/approve

@axsaucedo axsaucedo merged commit 5bb6f60 into SeldonIO:master Jul 10, 2020
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Executor dependencies that can be bumped without problems
4 participants