-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Executor/deps update - straightforward dependencies update #2099
Executor/deps update - straightforward dependencies update #2099
Conversation
/test integration |
Thu Jul 9 11:44:46 UTC 2020 impatient try |
Thu Jul 9 11:45:06 UTC 2020 impatient try |
Thu Jul 9 11:45:20 UTC 2020 impatient try |
Failure on |
Thu Jul 9 12:29:31 UTC 2020 impatient try |
/test integration |
@RafalSkolasinski: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
Thu Jul 9 13:01:05 UTC 2020 impatient try |
/test notebooks |
Thu Jul 9 13:41:56 UTC 2020 impatient try |
Maybe it could make sense to wait for #2093 to be merged and then rebase to ensure all works correctly with the updated deps (that should be the case tho, but just to make sure) |
Sure, sound good. Though seems the changes are orthogonal. On #2093 I wanted to base update of operator dep and k8s.io deps. |
@RafalSkolasinski seems integration tests pass 👍 |
Nice, momentum is good on this 🚀 |
/test integration |
Fri Jul 10 10:16:51 UTC 2020 impatient try |
Fri Jul 10 10:16:54 UTC 2020 impatient try |
Fri Jul 10 10:17:23 UTC 2020 impatient try |
Fri Jul 10 10:18:57 UTC 2020 impatient try |
Both notebooks and integrations pass 🚀 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes #2089.