Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: controller-runtime upgrade to v0.5.8 #2117

Merged
merged 1 commit into from
Jul 13, 2020
Merged

operator: controller-runtime upgrade to v0.5.8 #2117

merged 1 commit into from
Jul 13, 2020

Conversation

RafalSkolasinski
Copy link
Contributor

What this PR does / why we need it:

controller-runtime upgrade to v0.5.8

Which issue(s) this PR fixes:

Closes #2116

Special notes for your reviewer:

subtask of #2088

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks
/test integration

@seldondev
Copy link
Collaborator

Mon Jul 13 10:42:39 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2117/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2117 --build=1

@seldondev
Copy link
Collaborator

Mon Jul 13 10:42:50 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2117/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2117 --build=2

@seldondev
Copy link
Collaborator

Mon Jul 13 10:43:28 UTC 2020
The logs for [notebooks] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2117/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2117 --build=3

@seldondev
Copy link
Collaborator

Mon Jul 13 10:44:54 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2117/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2117 --build=4

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo
Copy link
Contributor

Integration and notebook tests pass 👍

@axsaucedo axsaucedo merged commit 0562e15 into SeldonIO:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade controller-runtime in Operator
3 participants