Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce number of times connecting to elastic #2120

Merged
merged 4 commits into from
Jul 15, 2020

Conversation

ryandawsonuk
Copy link
Contributor

for #2109

@seldondev
Copy link
Collaborator

Mon Jul 13 16:53:27 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2120/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2120 --build=2

@seldondev
Copy link
Collaborator

Mon Jul 13 16:53:27 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2120/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2120 --build=1

@seldondev
Copy link
Collaborator

Tue Jul 14 17:14:35 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2120/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2120 --build=3

@seldondev
Copy link
Collaborator

Tue Jul 14 17:14:38 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2120/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2120 --build=4

@seldondev seldondev added size/S and removed size/XS labels Jul 14, 2020
@seldondev
Copy link
Collaborator

Tue Jul 14 17:31:25 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2120/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2120 --build=6

@seldondev
Copy link
Collaborator

Tue Jul 14 17:31:50 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2120/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2120 --build=5

@axsaucedo
Copy link
Contributor

Looks good! Seems you need to run the linter, may be worth setting up the pre-commit hook https://docs.seldon.io/projects/seldon-core/en/v1.1.0/developer/contributing.html#coding-conventions or just running it directly. Once that's in should be good to merge!

@seldondev seldondev added size/L and removed size/S labels Jul 15, 2020
@seldondev
Copy link
Collaborator

Wed Jul 15 09:41:16 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2120/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2120 --build=8

@seldondev
Copy link
Collaborator

Wed Jul 15 09:41:17 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2120/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2120 --build=7

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo
Copy link
Contributor

/hold

@axsaucedo
Copy link
Contributor

Completely forgot to mention, would be good to add a note to the UPGRADING.md, maybe given the next release is 1.2.2, it may be worth just updating the header from 1.2.1->1.2.2 and add it as an extra heads up (ie that requst logger has been upgraded to new release). Not sure if there are other places in the docs where we provide the images.

@ryandawsonuk
Copy link
Contributor Author

@axsaucedo
Copy link
Contributor

Yeah, good point, it may be worth adding it onthe PR, and perhaps also on the upgrading section, although thinking about it there's not really a place where you would specify this in the seldon core config, so probably it's not as pressing.

/hold cancel

@seldondev
Copy link
Collaborator

Wed Jul 15 19:05:40 UTC 2020
The logs for [lint] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2120/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2120 --build=10

@seldondev
Copy link
Collaborator

Wed Jul 15 19:05:47 UTC 2020
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2120/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2120 --build=9

@seldondev seldondev merged commit bbe0fef into SeldonIO:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants