-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce number of times connecting to elastic #2120
reduce number of times connecting to elastic #2120
Conversation
Mon Jul 13 16:53:27 UTC 2020 impatient try |
Mon Jul 13 16:53:27 UTC 2020 impatient try |
Tue Jul 14 17:14:35 UTC 2020 impatient try |
Tue Jul 14 17:14:38 UTC 2020 impatient try |
Tue Jul 14 17:31:25 UTC 2020 impatient try |
Tue Jul 14 17:31:50 UTC 2020 impatient try |
Looks good! Seems you need to run the linter, may be worth setting up the pre-commit hook https://docs.seldon.io/projects/seldon-core/en/v1.1.0/developer/contributing.html#coding-conventions or just running it directly. Once that's in should be good to merge! |
Wed Jul 15 09:41:16 UTC 2020 impatient try |
Wed Jul 15 09:41:17 UTC 2020 impatient try |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
Completely forgot to mention, would be good to add a note to the UPGRADING.md, maybe given the next release is 1.2.2, it may be worth just updating the header from 1.2.1->1.2.2 and add it as an extra heads up (ie that requst logger has been upgraded to new release). Not sure if there are other places in the docs where we provide the images. |
Perhaps it needs adding to https://docs.seldon.io/projects/seldon-core/en/latest/reference/images.html |
Yeah, good point, it may be worth adding it onthe PR, and perhaps also on the upgrading section, although thinking about it there's not really a place where you would specify this in the seldon core config, so probably it's not as pressing. /hold cancel |
Wed Jul 15 19:05:40 UTC 2020 impatient try |
Wed Jul 15 19:05:47 UTC 2020 impatient try |
for #2109