Jenkins X add comment when pipeline finishes #2149

axsaucedo · 2020-07-16T20:30:32Z

PR contains:

Update all dependencies of Core Builder (will increase build speeds)
Moved Python Builder use to Core Builder as we use it for integration tests, and prepack builds for consistent environments
Added comment when build finishes so we can get notified (especially for long running tests like integration, notebooks and engine)
Modified Python tox tests so they can be run in parallel
Changed 0.0.0.0 to localhost on python tests so they can be run in parallel

seldondev · 2020-07-16T20:32:08Z

Thu Jul 16 20:32:07 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2149/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2149 --build=2

seldondev · 2020-07-16T20:34:55Z

Thu Jul 16 20:34:53 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2149/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2149 --build=4

seldondev · 2020-07-17T10:39:42Z

Fri Jul 17 10:39:41 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2149/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2149 --build=6

seldondev · 2020-07-17T10:45:50Z

Fri Jul 17 10:45:49 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2149/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2149 --build=8

seldondev · 2020-07-17T10:55:34Z

Fri Jul 17 10:55:33 UTC 2020
The logs for [lint] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2149/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2149 --build=10

seldondev · 2020-07-17T10:59:48Z

Fri Jul 17 10:59:47 UTC 2020
The logs for [lint] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2149/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2149 --build=12

seldondev · 2020-07-17T11:52:04Z

Fri Jul 17 11:52:03 UTC 2020
The logs for [lint] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2149/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2149 --build=14

seldondev · 2020-07-17T11:54:12Z

Fri Jul 17 11:54:11 UTC 2020
The logs for [lint] [16] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2149/16.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2149 --build=16

seldondev · 2020-07-17T11:58:32Z

Fri Jul 17 11:58:27 UTC 2020
The logs for [lint] [18] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2149/18.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2149 --build=18

seldondev · 2020-07-17T17:06:46Z

Fri Jul 17 17:06:42 UTC 2020
The logs for [lint] [20] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2149/20.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2149 --build=20

axsaucedo · 2020-07-18T05:55:16Z

/test this

seldondev · 2020-07-18T09:47:20Z

STARTING TEST [ pr-build # 52 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2149/52.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2149 --build=52

…localhost)

seldondev · 2020-07-18T09:50:28Z

STARTING TEST [ lint # 55 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2149/55.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2149 --build=55

seldondev · 2020-07-18T09:50:28Z

STARTING TEST [ pr-build # 54 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2149/54.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2149 --build=54

seldondev · 2020-07-18T09:56:29Z

SUCCESS [lint # 55] TEST PASSED ✅

Well done! 😎

seldondev · 2020-07-18T09:57:25Z

SUCCESS [pr-build # 54] TEST PASSED ✅

Well done! 😎

axsaucedo · 2020-07-18T10:00:52Z

PR contains:

Update all dependencies of Core Builder (will increase build speeds)
Moved Python Builder use to Core Builder as we use it for integration tests, and prepack builds for consistent environments
Added comment when build finishes so we can get notified (especially for long running tests like integration, notebooks and engine)
Modified Python tox tests so they can be run in parallel
Changed 0.0.0.0 to localhost on python tests so they can be run in parallel

/cc @cliveseldon
/cc @adriangonz

/test integration
/test notebooks
/test engine

seldondev · 2020-07-18T10:02:25Z

STARTING TEST [ notebooks # 56 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2149/56.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2149 --build=56

seldondev · 2020-07-18T10:02:29Z

STARTING TEST [ integration # 58 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2149/58.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2149 --build=58

seldondev · 2020-07-18T10:02:29Z

STARTING TEST [ engine # 57 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2149/57.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2149 --build=57

seldondev · 2020-07-18T10:50:40Z

SUCCESS [engine # 57] TEST PASSED ✅

Well done! 😎

seldondev · 2020-07-18T11:56:40Z

SUCCESS [integration # 58] TEST PASSED ✅

Well done! 😎

seldondev · 2020-07-18T12:04:05Z

SUCCESS [notebooks # 56] TEST PASSED ✅

Well done! 😎

ukclivecox · 2020-07-20T11:02:38Z

/approve

seldondev · 2020-07-20T11:03:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cliveseldon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

seldondev · 2020-07-20T11:10:09Z

STARTING TEST [ lint # 60 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2149/60.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2149 --build=60

seldondev · 2020-07-20T11:10:19Z

STARTING TEST [ pr-build # 59 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2149/59.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2149 --build=59

seldondev · 2020-07-20T11:27:32Z

SUCCESS [lint # 60] TEST PASSED ✅

Well done! 😎

axsaucedo · 2020-07-20T12:17:40Z

Strange, it seems the controller suite_test has failed with:

�[90m------------------------------�[0m
�[91m�[1mFailure [34.980 seconds]�[0m
�[91m�[1m[BeforeSuite] BeforeSuite �[0m
�[37m/workspace/source/operator/controllers/suite_test.go:142�[0m

  �[91mUnexpected error:
      <*errors.errorString | 0xc0003656c0>: {
          s: "timed out waiting for the condition",
      }
      timed out waiting for the condition
  occurred�[0m

  /workspace/source/operator/controllers/suite_test.go:158
�[90m------------------------------�[0m

axsaucedo · 2020-07-20T12:18:08Z

/test this

seldondev · 2020-07-20T12:19:52Z

STARTING TEST [ pr-build # 61 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2149/61.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2149 --build=61

seldondev · 2020-07-20T12:26:26Z

SUCCESS [pr-build # 61] TEST PASSED ✅

Well done! 😎

axsaucedo · 2020-07-20T12:28:15Z

Strange, it seems the operator test had a spike in the memory usage:

It went up to 7.2GB, we should investigate further

Added pipeline pre/post check

fef171f

seldondev added do-not-merge/work-in-progress size/S labels Jul 16, 2020

Fixed formating on yaml

501cbc7

updated pipeline to test other pre/post

fd73daa

Added override for temp fast build

781be79

seldondev added size/M and removed size/S labels Jul 17, 2020

Added override for temp fast build

914888d

Testing main comment

d2bdaeb

Testing main comment

ea7064b

Testing main comment

aa7524c

Testing main comment

7be1b1c

axsaucedo added 3 commits July 17, 2020 17:48

Updated core builder

65d3032

Updated jenkins files

ad9c917

Updated makefiles

7585c98

seldondev added size/L and removed size/M labels Jul 17, 2020

Updated makefiles

a04ed28

Updated python test so it can be run in parallel (changed 0.0.0.0 to …

70b8516

…localhost)

seldondev requested review from adriangonz and ukclivecox July 18, 2020 10:00

axsaucedo changed the title ~~WIP: Jenkins X add comment when pipeline finishes~~ Jenkins X add comment when pipeline finishes Jul 18, 2020

seldondev removed the do-not-merge/work-in-progress label Jul 18, 2020

seldondev added the approved label Jul 20, 2020

seldondev merged commit 9d3bbfc into SeldonIO:master Jul 20, 2020

axsaucedo mentioned this pull request Jul 20, 2020

WIP: Evaluation of Reverting "Jenkins X add comment when pipeline finishes" to remove test flakiness #2174

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jenkins X add comment when pipeline finishes #2149

Jenkins X add comment when pipeline finishes #2149

axsaucedo commented Jul 16, 2020 •

edited

Loading

seldondev commented Jul 16, 2020

seldondev commented Jul 16, 2020

seldondev commented Jul 17, 2020

seldondev commented Jul 17, 2020

seldondev commented Jul 17, 2020

seldondev commented Jul 17, 2020

seldondev commented Jul 17, 2020

seldondev commented Jul 17, 2020

seldondev commented Jul 17, 2020

seldondev commented Jul 17, 2020

axsaucedo commented Jul 18, 2020

seldondev commented Jul 18, 2020

seldondev commented Jul 18, 2020

seldondev commented Jul 18, 2020

seldondev commented Jul 18, 2020

seldondev commented Jul 18, 2020

axsaucedo commented Jul 18, 2020

seldondev commented Jul 18, 2020

seldondev commented Jul 18, 2020

seldondev commented Jul 18, 2020

seldondev commented Jul 18, 2020

seldondev commented Jul 18, 2020

seldondev commented Jul 18, 2020

ukclivecox commented Jul 20, 2020

seldondev commented Jul 20, 2020

seldondev commented Jul 20, 2020

seldondev commented Jul 20, 2020

seldondev commented Jul 20, 2020

axsaucedo commented Jul 20, 2020

axsaucedo commented Jul 20, 2020

seldondev commented Jul 20, 2020

seldondev commented Jul 20, 2020

axsaucedo commented Jul 20, 2020

Jenkins X add comment when pipeline finishes #2149

Jenkins X add comment when pipeline finishes #2149

Conversation

axsaucedo commented Jul 16, 2020 • edited Loading

seldondev commented Jul 16, 2020

seldondev commented Jul 16, 2020

seldondev commented Jul 17, 2020

seldondev commented Jul 17, 2020

seldondev commented Jul 17, 2020

seldondev commented Jul 17, 2020

seldondev commented Jul 17, 2020

seldondev commented Jul 17, 2020

seldondev commented Jul 17, 2020

seldondev commented Jul 17, 2020

axsaucedo commented Jul 18, 2020

seldondev commented Jul 18, 2020

STARTING TEST [ pr-build # 52 ]

seldondev commented Jul 18, 2020

STARTING TEST [ lint # 55 ]

seldondev commented Jul 18, 2020

STARTING TEST [ pr-build # 54 ]

seldondev commented Jul 18, 2020

SUCCESS [lint # 55] TEST PASSED ✅

seldondev commented Jul 18, 2020

SUCCESS [pr-build # 54] TEST PASSED ✅

axsaucedo commented Jul 18, 2020

seldondev commented Jul 18, 2020

STARTING TEST [ notebooks # 56 ]

seldondev commented Jul 18, 2020

STARTING TEST [ integration # 58 ]

seldondev commented Jul 18, 2020

STARTING TEST [ engine # 57 ]

seldondev commented Jul 18, 2020

SUCCESS [engine # 57] TEST PASSED ✅

seldondev commented Jul 18, 2020

SUCCESS [integration # 58] TEST PASSED ✅

seldondev commented Jul 18, 2020

SUCCESS [notebooks # 56] TEST PASSED ✅

ukclivecox commented Jul 20, 2020

seldondev commented Jul 20, 2020

seldondev commented Jul 20, 2020

STARTING TEST [ lint # 60 ]

seldondev commented Jul 20, 2020

STARTING TEST [ pr-build # 59 ]

seldondev commented Jul 20, 2020

SUCCESS [lint # 60] TEST PASSED ✅

axsaucedo commented Jul 20, 2020

axsaucedo commented Jul 20, 2020

seldondev commented Jul 20, 2020

STARTING TEST [ pr-build # 61 ]

seldondev commented Jul 20, 2020

SUCCESS [pr-build # 61] TEST PASSED ✅

axsaucedo commented Jul 20, 2020

axsaucedo commented Jul 16, 2020 •

edited

Loading