-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error handler for R #2153
Add error handler for R #2153
Conversation
Hi @johnny-butter. Thanks for your PR. I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
/ok-to-test |
Thanks for this! |
/approve |
Fri Jul 17 12:23:36 UTC 2020 impatient try |
Fri Jul 17 12:23:39 UTC 2020 impatient try |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cliveseldon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fri Jul 17 14:58:31 UTC 2020 impatient try |
Fri Jul 17 14:58:47 UTC 2020 impatient try |
@cliveseldon I fixed a typo that I didn't notice before |
What this PR does / why we need it:
raise an error in R code, can not get the message we create
response now:
expect response:
so add an error handler to catch
seldon_microservice_error
which is used to create a custom errorusage:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: