Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handler for R #2153

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Add error handler for R #2153

merged 2 commits into from
Jul 17, 2020

Conversation

johnny-butter
Copy link
Contributor

What this PR does / why we need it:
raise an error in R code, can not get the message we create

response now:
螢幕快照 2020-07-17 下午4 17 14

expect response:
螢幕快照 2020-07-17 下午4 20 10

so add an error handler to catch seldon_microservice_error which is used to create a custom error

usage:

source("seldon_microservice_error.R")

predict.model_f <- function() {
  seldon_microservice_error("param X wrong", 400)
}

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Added custom error for R

@seldondev
Copy link
Collaborator

Hi @johnny-butter. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@ukclivecox
Copy link
Contributor

/ok-to-test

@ukclivecox
Copy link
Contributor

Thanks for this!

@ukclivecox
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

Fri Jul 17 12:23:36 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2153/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2153 --build=1

@seldondev
Copy link
Collaborator

Fri Jul 17 12:23:39 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2153/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2153 --build=2

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Fri Jul 17 14:58:31 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2153/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2153 --build=3

@seldondev
Copy link
Collaborator

Fri Jul 17 14:58:47 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2153/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2153 --build=4

@johnny-butter
Copy link
Contributor Author

@cliveseldon I fixed a typo that I didn't notice before

@seldondev seldondev merged commit 296d024 into SeldonIO:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants