Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: update images reference doc for 1.2.2 release #2167

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

gsunner
Copy link
Contributor

@gsunner gsunner commented Jul 20, 2020

What this PR does / why we need it:

This prep fo rthe 1.2.2 release

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign gsunner
You can assign the PR to them by writing /assign @gsunner in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

STARTING TEST [ lint # 2 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2167/2.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2167 --build=2

@seldondev
Copy link
Collaborator

STARTING TEST [ pr-build # 1 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2167/1.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2167 --build=1

@seldondev
Copy link
Collaborator

SUCCESS [lint # 2] TEST PASSED ✅

Well done! 😎

@seldondev
Copy link
Collaborator

SUCCESS [pr-build # 1] TEST PASSED ✅

Well done! 😎

@axsaucedo axsaucedo merged commit 46f35b4 into SeldonIO:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants