Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing disclaimer in executor #2172

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Routing disclaimer in executor #2172

merged 1 commit into from
Jul 21, 2020

Conversation

ukclivecox
Copy link
Contributor

@ukclivecox ukclivecox commented Jul 20, 2020

Fixes #2139

Updated documentation about routing when using the Go executor.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cliveseldon
You can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

STARTING TEST [ lint # 2 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2172/2.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2172 --build=2

@seldondev
Copy link
Collaborator

STARTING TEST [ pr-build # 1 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2172/1.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2172 --build=1

@seldondev
Copy link
Collaborator

SUCCESS [lint # 2] TEST PASSED ✅

Well done! 😎

@axsaucedo
Copy link
Contributor

/test this

1 similar comment
@axsaucedo
Copy link
Contributor

/test this

@seldondev
Copy link
Collaborator

STARTING TEST [ pr-build # 3 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2172/3.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2172 --build=3

@seldondev
Copy link
Collaborator

STARTING TEST [ pr-build # 4 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2172/4.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2172 --build=4

@seldondev
Copy link
Collaborator

SUCCESS [pr-build # 4] TEST PASSED ✅

Well done! 😎

@axsaucedo
Copy link
Contributor

/test this

@seldondev
Copy link
Collaborator

STARTING TEST [ pr-build # 5 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2172/5.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2172 --build=5

@seldondev
Copy link
Collaborator

SUCCESS [pr-build # 5] TEST PASSED ✅

Well done! 😎

@axsaucedo
Copy link
Contributor

/test this

1 similar comment
@axsaucedo
Copy link
Contributor

/test this

@seldondev
Copy link
Collaborator

STARTING TEST [ pr-build # 7 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2172/7.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2172 --build=7

@seldondev
Copy link
Collaborator

STARTING TEST [ pr-build # 6 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2172/6.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2172 --build=6

@axsaucedo
Copy link
Contributor

/test this

1 similar comment
@axsaucedo
Copy link
Contributor

/test this

@seldondev
Copy link
Collaborator

STARTING TEST [ pr-build # 8 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2172/8.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2172 --build=8

@seldondev
Copy link
Collaborator

STARTING TEST [ pr-build # 9 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2172/9.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2172 --build=9

@seldondev
Copy link
Collaborator

@cliveseldon: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pr-build 65d487f link /test this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@axsaucedo axsaucedo merged commit 5799cf1 into SeldonIO:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add to docs clarification on Routing not available in executor
3 participants