Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Jenkins X add comment when pipeline finishes " #2177

Merged
merged 28 commits into from
Jul 21, 2020
Merged

Revert "Jenkins X add comment when pipeline finishes " #2177

merged 28 commits into from
Jul 21, 2020

Conversation

axsaucedo
Copy link
Contributor

Initial revert for #2175

axsaucedo added 28 commits July 20, 2020 20:25
@axsaucedo
Revert "Updated python test so it can be run in parallel (changed 0.0…
f88ca38 
….0.0 to localhost)"

This reverts commit 9d3bbfc.
@axsaucedo
Revert "Updated success/info pr"
7a5ea2f 
This reverts commit 6576a8b.
@axsaucedo
Revert "Updated success/info pr"
adc4dab 
This reverts commit c46ecbf.
@axsaucedo
Revert "Updated success/info pr"
08a09b9 
This reverts commit 5ad58b6.
@axsaucedo
Revert "Updated success/info pr"
3a624dc 
This reverts commit 5a3b42c.
@axsaucedo
Revert "Updated success/info pr"
972a7a7 
This reverts commit 638963d.
@axsaucedo
Revert "test comment£"
44e60e6 
This reverts commit 520fc8c.
@axsaucedo
Revert "Added comment when success"
fe5e93d 
This reverts commit ccf6498.
@axsaucedo
Revert "Updated makefile typo"
8d942a8 
This reverts commit 819f381.
@axsaucedo
Revert "Updated typo"
36ccff8 
This reverts commit ecf517e.
@axsaucedo
Revert "Added parallel testing for python"
5428547 
This reverts commit f098f0a.
@axsaucedo
Revert "Update dockerfile"
4f17d09 
This reverts commit 320cbd7.
@axsaucedo
Revert "Updated image"
fded7c3 
This reverts commit 34727ac.
@axsaucedo
Revert "Reverted python"
82d02c9 
This reverts commit ab3bc2f.
@axsaucedo
Revert "Updated makefiles"
c48b0d9 
This reverts commit f57b7fe.
@axsaucedo
Revert "Updated makefiles"
924d353 
This reverts commit 9dd5dc4.
@axsaucedo
Revert "Updated makefiles"
97f8e5f 
This reverts commit 9796968.
@axsaucedo
Revert "Updated jenkins files"
c9f4015 
This reverts commit 4643e31.
@axsaucedo
Revert "Updated core builder"
56fd889 
This reverts commit 0ad2801.
@axsaucedo
Revert "Testing main comment"
af52227 
This reverts commit ede7fec.
@axsaucedo
Revert "Testing main comment"
40b90bb 
This reverts commit e7f4c93.
@axsaucedo
Revert "Testing main comment"
89b7fa0 
This reverts commit 57103c0.
@axsaucedo
Revert "Testing main comment"
2dfd087 
This reverts commit a9d3dd8.
@axsaucedo
Revert "Added override for temp fast build"
8ff497f 
This reverts commit 4ed7527.
@axsaucedo
Revert "Added override for temp fast build"
49cae93 
This reverts commit 1ed83cf.
@axsaucedo
Revert "updated pipeline to test other pre/post"
86245a9 
This reverts commit a125995.
@axsaucedo
Revert "Fixed formating on yaml"
7147337 
This reverts commit 4768bdf.
@axsaucedo
Revert "Added pipeline pre/post check"
b0d674e 
This reverts commit 380ea44.
@seldondev
Copy link
Collaborator

Tue Jul 21 09:47:57 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2177/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2177 --build=1

@seldondev
Copy link
Collaborator

Tue Jul 21 09:48:25 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2177/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2177 --build=2

@axsaucedo
Copy link
Contributor Author

Ok all tests seem to pass on PR 👍
/approve

@axsaucedo axsaucedo merged commit 979ccf0 into master Jul 21, 2020
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RafalSkolasinski RafalSkolasinski deleted the revert-2149-2148_jenkins_x_pipelines branch February 21, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axsaucedo @seldondev