Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tensorflow protocol explanations #2188

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Allow tensorflow protocol explanations #2188

merged 2 commits into from
Jul 24, 2020

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2185

Special notes for your reviewer:

  • Also changes tensorflow http server to all <model_name>:predict as before only allowed <model_name>/:predict
  • Also fixes some typos that crept in for protocol_examples and seldon_setup notebooks

Does this PR introduce a user-facing change?:

NONE

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@ukclivecox ukclivecox requested a review from axsaucedo July 23, 2020 18:10
@seldondev
Copy link
Collaborator

Thu Jul 23 18:12:28 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2188/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2188 --build=2

@seldondev
Copy link
Collaborator

Thu Jul 23 18:12:31 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2188/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2188 --build=1

Copy link
Contributor

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notebooks look good! ADded a couple of points / questions but other than that looks good to go

executor/api/rest/server.go Show resolved Hide resolved
@axsaucedo
Copy link
Contributor

/test integration
/test notebooks

@seldondev
Copy link
Collaborator

Thu Jul 23 18:20:22 UTC 2020
The logs for [notebooks] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2188/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2188 --build=3

@seldondev
Copy link
Collaborator

Thu Jul 23 18:20:34 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2188/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2188 --build=4

@ukclivecox
Copy link
Contributor Author

/test this

@seldondev
Copy link
Collaborator

Thu Jul 23 18:42:37 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2188/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2188 --build=5

@seldondev
Copy link
Collaborator

Fri Jul 24 10:46:19 UTC 2020
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2188/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2188 --build=6

@seldondev
Copy link
Collaborator

Fri Jul 24 10:46:23 UTC 2020
The logs for [lint] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2188/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2188 --build=7

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox
Copy link
Contributor Author

/test this

@seldondev
Copy link
Collaborator

Fri Jul 24 11:14:15 UTC 2020
The logs for [pr-build] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2188/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2188 --build=8

@seldondev seldondev merged commit e84f710 into SeldonIO:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explainers are hardwired to seldon protocol
3 participants