Change Outlier call depending on type #2205
Conversation
|
Mon Jul 27 19:04:26 UTC 2020 impatient try |
|
Mon Jul 27 19:04:35 UTC 2020 impatient try |
| return_instance_score=ret_instance_score, | ||
| ) | ||
| op_preds = {} | ||
| name = self.model.meta['name'] |
There was a problem hiding this comment.
Would model meta name always be set? Otherwise may be worth adding .get("name", None) to avoid exception
There was a problem hiding this comment.
I think it should always be there: https://github.com/SeldonIO/alibi-detect/blob/ca9af48e3590121daff39a6c5d76261838867d3c/alibi_detect/utils/saving.py#L68
There was a problem hiding this comment.
Ah ok i seen, thanks for the reference
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Change outlier call based on loaded detector
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: