Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated kfserving base image #2261

Merged
merged 2 commits into from
Aug 13, 2020
Merged

Conversation

axsaucedo
Copy link
Contributor

Fixes #2236

@axsaucedo
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign axsaucedo
You can assign the PR to them by writing /assign @axsaucedo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -67,6 +67,8 @@ spec:
value: ''
- name: RELATED_IMAGE_EXPLAINER
value: ''
- name: RELATED_IMAGE_MOCK_CLASSIFIER
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this change wasn't reflected from another PR

@seldondev
Copy link
Collaborator

Mon Aug 10 12:43:49 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2261/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2261 --build=3

@seldondev
Copy link
Collaborator

Mon Aug 10 12:43:53 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2261/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2261 --build=2

@seldondev
Copy link
Collaborator

Mon Aug 10 12:44:05 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2261/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2261 --build=1

@axsaucedo
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Mon Aug 10 12:52:58 UTC 2020
The logs for [integration] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2261/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2261 --build=6

@axsaucedo
Copy link
Contributor Author

/test this

@seldondev
Copy link
Collaborator

Mon Aug 10 14:26:43 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2261/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2261 --build=7

@axsaucedo
Copy link
Contributor Author

It seems failed ones have been flaky ones (rolling update) - retesting
/test integration

@seldondev
Copy link
Collaborator

Mon Aug 10 15:40:04 UTC 2020
The logs for [integration] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2261/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2261 --build=8

@seldondev
Copy link
Collaborator

@axsaucedo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 6a9f52a link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@axsaucedo
Copy link
Contributor Author

It seems all tests pass except test test_label_update, I will run locally to assess

Copy link
Contributor

@ryandawsonuk ryandawsonuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@axsaucedo axsaucedo merged commit d6104b0 into SeldonIO:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to use KFserving 0.4.0 artifacts
3 participants