Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MPL source code to images #2264

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Add MPL source code to images #2264

merged 2 commits into from
Aug 11, 2020

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:
Adds MPL dependent libraries source code to images of Operator and Executor.

Which issue(s) this PR fixes:

Fixes #2263

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@seldondev
Copy link
Collaborator

Tue Aug 11 12:31:49 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2264/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2264 --build=2

@seldondev
Copy link
Collaborator

Tue Aug 11 12:31:52 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2264/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2264 --build=1

@seldondev
Copy link
Collaborator

Tue Aug 11 12:46:30 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2264/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2264 --build=4

@seldondev
Copy link
Collaborator

Tue Aug 11 12:46:37 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2264/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2264 --build=3

Copy link
Contributor

@RafalSkolasinski RafalSkolasinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

In the future we can consider adding full source code of dependencies using go mod vendor

@RafalSkolasinski RafalSkolasinski self-requested a review August 11, 2020 13:21
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RafalSkolasinski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 500ab1c into SeldonIO:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add source mirroring for MPL licensed dependencies
3 participants