-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update distributed-tracing.md #2323
Conversation
Update it to reflect latest version (which right now corresponds to 1.18). They automatically link latest to the version number so `latest` will always work
Hi @omerfsen. Thanks for your PR. I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
/ok-to-test |
Tue Aug 25 12:45:11 UTC 2020 impatient try |
Tue Aug 25 12:45:15 UTC 2020 impatient try |
@omerfsen would it not be better to choose a fixed version otherwise we risk breaking changes? Could we not set to 1.18? |
Sure.
…On Wed, Aug 26, 2020 at 11:29 AM cliveseldon ***@***.***> wrote:
@omerfsen <https://github.com/omerfsen> would it not be better to choose
a fixed version otherwise we risk breaking changes? Could we not set to
1.18?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2323 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHCULG6RQ2RROWZUBCCZ3SDSCTPYDANCNFSM4QKRWFTQ>
.
|
Wed Aug 26 14:35:45 UTC 2020 impatient try |
Wed Aug 26 14:35:49 UTC 2020 impatient try |
1.16 --> 1.18 |
done! |
Wed Aug 26 14:36:58 UTC 2020 impatient try |
Wed Aug 26 14:37:06 UTC 2020 impatient try |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cliveseldon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test notebooks |
Can you rebase from master to fix lint error @omerfsen ? |
Thu Aug 27 09:51:37 UTC 2020 impatient try |
@omerfsen: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
Update it to reflect latest version (which right now corresponds to 1.18). They automatically link latest to the version number so
latest
will always workWhat this PR does / why we need it:
Updates jaeger to latest version
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: