Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow terminationGracePeriodSeconds to be overridden #2345

Merged
merged 4 commits into from
Sep 17, 2020
Merged

Allow terminationGracePeriodSeconds to be overridden #2345

merged 4 commits into from
Sep 17, 2020

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:
Allow terminationGracePeriodSeconds to be overridden.

Which issue(s) this PR fixes:

Fixes #2332

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cliveseldon
You can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Fri Aug 28 15:47:42 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2345/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2345 --build=1

@seldondev
Copy link
Collaborator

Fri Aug 28 15:47:53 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2345/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2345 --build=2

@seldondev seldondev added size/S and removed size/XS labels Aug 28, 2020
@seldondev
Copy link
Collaborator

Fri Aug 28 16:02:20 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2345/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2345 --build=4

@seldondev
Copy link
Collaborator

Fri Aug 28 16:02:24 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2345/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2345 --build=3

@adriangonz
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Tue Sep 1 09:08:19 UTC 2020
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2345/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2345 --build=5

@adriangonz
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Wed Sep 2 07:22:56 UTC 2020
The logs for [integration] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2345/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2345 --build=6

Copy link
Contributor

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added a question

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Wed Sep 16 18:05:47 UTC 2020
The logs for [integration] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2345/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2345 --build=7

@seldondev
Copy link
Collaborator

@cliveseldon: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 6c11a13 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Thu Sep 17 06:55:45 UTC 2020
The logs for [pr-build] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2345/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2345 --build=8

@seldondev
Copy link
Collaborator

Thu Sep 17 06:55:48 UTC 2020
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2345/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2345 --build=9

@seldondev
Copy link
Collaborator

Thu Sep 17 06:56:05 UTC 2020
The logs for [integration] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2345/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2345 --build=10

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Thu Sep 17 07:37:17 UTC 2020
The logs for [integration] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2345/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2345 --build=11

@axsaucedo axsaucedo merged commit b98d776 into SeldonIO:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TerminationGracePeriodSeconds not respected in CRD
4 participants