-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow terminationGracePeriodSeconds to be overridden #2345
Allow terminationGracePeriodSeconds to be overridden #2345
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fri Aug 28 15:47:42 UTC 2020 impatient try |
Fri Aug 28 15:47:53 UTC 2020 impatient try |
Fri Aug 28 16:02:20 UTC 2020 impatient try |
Fri Aug 28 16:02:24 UTC 2020 impatient try |
/test integration |
Tue Sep 1 09:08:19 UTC 2020 impatient try |
/test integration |
Wed Sep 2 07:22:56 UTC 2020 impatient try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, added a question
/test integration |
Wed Sep 16 18:05:47 UTC 2020 impatient try |
@cliveseldon: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
/test integration |
Thu Sep 17 06:55:45 UTC 2020 impatient try |
Thu Sep 17 06:55:48 UTC 2020 impatient try |
Thu Sep 17 06:56:05 UTC 2020 impatient try |
/test integration |
Thu Sep 17 07:37:17 UTC 2020 impatient try |
What this PR does / why we need it:
Allow terminationGracePeriodSeconds to be overridden.
Which issue(s) this PR fixes:
Fixes #2332
Special notes for your reviewer:
Does this PR introduce a user-facing change?: