-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java JNI (JPype) Wrapper #2374
Java JNI (JPype) Wrapper #2374
Conversation
Thu Sep 3 13:27:26 UTC 2020 impatient try |
Thu Sep 3 13:27:32 UTC 2020 impatient try |
While this is still a WIP PR, it would be great to hear your thoughts about the changes introduced in this PR @cliveseldon @axsaucedo @RafalSkolasinski . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @adriangonz ! I added a couple of comments, would be great to hear your thoughts
incubating/wrappers/s2i/java-jni/test/model-template-app/pom.xml
Outdated
Show resolved
Hide resolved
a15e846
to
f8f09ce
Compare
Fri Sep 18 17:10:16 UTC 2020 impatient try |
Fri Sep 18 17:10:23 UTC 2020 impatient try |
/cc @RafalSkolasinski @axsaucedo I just added some tests to this PR using the new JNI wrapper. I tried to also add some for the pure Java wrapper but there was some issue there. This can be tackled on a separate PR though. This should now be ready for review 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THis is great! Nice one @adriangonz - should be good to go once integration passes (excluding known tests with issues)
/approve
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Mon Sep 21 07:53:08 UTC 2020 impatient try |
Mon Sep 21 07:53:17 UTC 2020 impatient try |
What this PR does / why we need it:
Add an experimental option to wrap Java models which leverages the Python inference server under the hood. The communication between the Python and Java side is managed through JNI using JPype.
To make the interop more efficient, this PR also introduces a method to disable the payload serialisation / deserialisation on the Python side (so that is managed by Java). This is controlled through the
PAYLOAD_PASSTHROUGH
env variable.To Do:
0.3.0
version of Java wrapperAdd example(moved to Add example for Java wrapper using JNI #2458)Which issue(s) this PR fixes:
Work towards #1344
Special notes for your reviewer:
This works is considered as an incubating project.
Does this PR introduce a user-facing change?: