Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated setup.py to work with security CI #2398

Merged
merged 3 commits into from
Sep 8, 2020

Conversation

axsaucedo
Copy link
Contributor

Fixes #2065

Context

  • Moving to setup.py broke the CI script
  • After investigation it was the open("local/path/file") that was breaking snyk
  • This relative path was removed and updated release.py

@axsaucedo
Copy link
Contributor Author

/test securitychecks

@seldondev
Copy link
Collaborator

Tue Sep 8 10:19:55 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2398/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2398 --build=2

@seldondev
Copy link
Collaborator

Tue Sep 8 10:20:02 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2398/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2398 --build=1

@seldondev
Copy link
Collaborator

Tue Sep 8 10:20:23 UTC 2020
The logs for [securitychecks] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2398/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2398 --build=3

@seldondev
Copy link
Collaborator

@axsaucedo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
securitychecks 0d7ec76 link /test securitychecks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@axsaucedo
Copy link
Contributor Author

Perfect, @adriangonz it seems it now has failed for the right reason (the pyyaml security check), so all working with python now, should be good to go!

@seldondev
Copy link
Collaborator

Tue Sep 8 11:49:48 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2398/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2398 --build=4

@seldondev
Copy link
Collaborator

Tue Sep 8 11:49:56 UTC 2020
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2398/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2398 --build=5

@axsaucedo
Copy link
Contributor Author

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 3b3639e into SeldonIO:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure all model servers have pinned requirements and the full requirements.txt is included in the docs
2 participants