Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ksonnet and Helm Charts #247

Merged
merged 5 commits into from
Oct 8, 2018
Merged

Update Ksonnet and Helm Charts #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7d6c74e
refactor ksonnet so same as kubeflow ksonnet
ukclivecox Oct 6, 2018
18f393a
updated ksonnet prototypes
ukclivecox Oct 7, 2018
042fb72
Update helm example and charts
ukclivecox Oct 7, 2018
4acd590
update core notebooks from testng
ukclivecox Oct 7, 2018
d106fdb
remove cloud specific notebooks
ukclivecox Oct 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions docs/getting_started/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,4 @@ You can use ```kubectl``` to deploy your ML service like any other Kubernetes re
# Next Steps

* [Jupyter notebooks showing worked examples](../../readme.md#quick-start)
* Templated Helm Charts:
* [Single Model with optional Outlier Detector](https://github.com/SeldonIO/seldon-core/tree/master/helm-charts/seldon-single-model)
* [AB Test between two models](https://github.com/SeldonIO/seldon-core/tree/master/helm-charts/seldon-abtest)
* [Multi-Armed Bandit of two models](https://github.com/SeldonIO/seldon-core/tree/master/helm-charts/seldon-mab)
* [Integration with other machine learning frameworks](../../readme.md#integrations)

5 changes: 5 additions & 0 deletions docs/install.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,8 @@ Notes

* [Install Seldon as part of Kubeflow.](https://www.kubeflow.org/docs/guides/components/seldon/#seldon-serving)
* Kubeflow presently runs 0.1 version of seldon-core. This will be updated to 0.2 in the near future.


# Next Steps

* [Jupyter notebooks showing worked examples](../readme.md#quick-start)
6 changes: 3 additions & 3 deletions helm-charts/seldon-abtest/templates/ab_test_1pod.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
"labels": {
"app": "seldon"
},
"name": "seldon-deployment-example"
"name": "{{ .Release.Name }}"
},
"spec": {
"name": "{{ .Values.name }}",
"name": "{{ .Release.Name }}",
{{- if .Values.oauth.key }}
"oauth_key": "{{ .Values.oauth.key }}",
"oauth_secret": "{{ .Values.oauth.secret }}",
Expand Down Expand Up @@ -46,7 +46,7 @@
}
}],
"graph": {
"name": "random-ab-test",
"name": "{{ .Release.Name }}",
"endpoint":{},
"implementation":"RANDOM_ABTEST",
"parameters": [
Expand Down
6 changes: 3 additions & 3 deletions helm-charts/seldon-abtest/templates/ab_test_2pods.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
"labels": {
"app": "seldon"
},
"name": "seldon-deployment"
"name": "{{ .Release.Name }}"
},
"spec": {
"name": "{{ .Values.name }}",
"name": "{{ .Release.Name }}",
{{- if .Values.oauth.key }}
"oauth_key": "{{ .Values.oauth.key }}",
"oauth_secret": "{{ .Values.oauth.secret }}",
Expand Down Expand Up @@ -56,7 +56,7 @@
}
}],
"graph": {
"name": "random-ab-test",
"name": "{{ .Release.Name }}",
"endpoint":{},
"implementation":"RANDOM_ABTEST",
"parameters": [
Expand Down
1 change: 0 additions & 1 deletion helm-charts/seldon-abtest/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
separate_pods: true
name: my-abtest
modela:
image:
name: seldonio/mock_classifier:1.0
Expand Down
4 changes: 2 additions & 2 deletions helm-charts/seldon-mab/templates/mab.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
"labels": {
"app": "seldon"
},
"name": "seldon-deployment"
"name": "{{ .Release.Name }}"
},
"spec": {
"name": "{{ .Values.name }}",
"name": "{{ .Release.Name }}",
{{- if .Values.oauth.key }}
"oauth_key": "{{ .Values.oauth.key }}",
"oauth_secret": "{{ .Values.oauth.secret }}",
Expand Down
1 change: 0 additions & 1 deletion helm-charts/seldon-mab/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
name: my-mab
modela:
image:
name: seldonio/mock_classifier:1.0
Expand Down
6 changes: 3 additions & 3 deletions helm-charts/seldon-single-model/templates/model.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
"labels": {
"app": "seldon"
},
"name": "seldon-model"
"name": "{{ .Release.Name }}"
},
"spec": {
"name": "test-deployment",
"name": "{{ .Release.Name }}",
{{- if .Values.oauth.key }}
"oauth_key": "{{ .Values.oauth.key }}",
"oauth_secret": "{{ .Values.oauth.secret }}",
Expand Down Expand Up @@ -80,7 +80,7 @@
{{- if .Values.outlier_detection.enabled }}
]}
{{- end }},
"name": "{{ .Values.name }}",
"name": "{{ .Release.Name }}",
"replicas": {{ .Values.replicas }},
"labels": {
"version" : "v1"
Expand Down
2 changes: 1 addition & 1 deletion helm-charts/seldon-single-model/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ model:
outlier_detection:
enabled: false
image:
name: seldonio/outlier_mahalanobis:0.2
name: seldonio/outlier_mahalanobis:0.3
n_components: 2
name: outlier-detector
replicas: 1
Expand Down
Loading