Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert change to retention period - leave default and let user override #2472

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

ryandawsonuk
Copy link
Contributor

follow up to #2401

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ryandawsonuk
You can assign the PR to them by writing /assign @ryandawsonuk in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Tue Sep 22 13:30:54 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2472/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2472 --build=1

@seldondev
Copy link
Collaborator

Tue Sep 22 13:30:53 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2472/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2472 --build=2

@ryandawsonuk
Copy link
Contributor Author

/test this

@seldondev
Copy link
Collaborator

Tue Sep 22 14:01:17 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2472/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2472 --build=3

@ukclivecox ukclivecox added this to the 1.3 milestone Sep 24, 2020
@ukclivecox ukclivecox merged commit d67911f into SeldonIO:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants