Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add prototype of distributed inference computing with Seldon & Ray #2517

Merged
merged 3 commits into from
Nov 10, 2020
Merged

add prototype of distributed inference computing with Seldon & Ray #2517

merged 3 commits into from
Nov 10, 2020

Conversation

RafalSkolasinski
Copy link
Contributor

What this PR does / why we need it:

Example on using Ray to distribute single request as mini-batches.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@RafalSkolasinski RafalSkolasinski marked this pull request as draft October 2, 2020 21:38
@seldondev
Copy link
Collaborator

Fri Oct 2 21:39:57 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2517/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2517 --build=1

@seldondev
Copy link
Collaborator

Fri Oct 2 21:51:17 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2517/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2517 --build=3

@seldondev
Copy link
Collaborator

Fri Oct 2 21:51:18 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2517/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2517 --build=4

@seldondev
Copy link
Collaborator

Fri Oct 2 21:53:32 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2517/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2517 --build=2

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Wed Oct 14 15:05:51 UTC 2020
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2517/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2517 --build=5

@axsaucedo axsaucedo changed the title add prototype of distributed inference computing with Seldon & Ray WIP: add prototype of distributed inference computing with Seldon & Ray Oct 29, 2020
@RafalSkolasinski RafalSkolasinski marked this pull request as ready for review November 9, 2020 11:16
@seldondev
Copy link
Collaborator

Mon Nov 9 11:17:14 UTC 2020
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2517/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2517 --build=6

@seldondev
Copy link
Collaborator

Mon Nov 9 11:17:25 UTC 2020
The logs for [lint] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2517/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2517 --build=7

@RafalSkolasinski RafalSkolasinski changed the title WIP: add prototype of distributed inference computing with Seldon & Ray add prototype of distributed inference computing with Seldon & Ray Nov 9, 2020
axsaucedo
axsaucedo suggested changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of small comments

examples/ray/batch-split-proxy/Dockerfile Outdated
@@ -0,0 +1,22 @@

FROM seldonio/seldon-core-s2i-python37:1.3.0-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to 1.5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.5.0-dev?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't expect this to be frequently rebuild so I'd rather go with stable base, 1.4.0 maybe?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shoudl be updated by the release script, so it should be in-line with the version in version.txt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

examples/ray/batch-split-proxy/training/requirements.txt
@@ -0,0 +1,7 @@
alibi==0.5.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the current master uses 0.5.5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only used to download training dataset.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok should be fine

@seldondev
Copy link
Collaborator

Mon Nov 9 17:11:49 UTC 2020
The logs for [pr-build] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2517/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2517 --build=8

@seldondev
Copy link
Collaborator

Mon Nov 9 17:11:53 UTC 2020
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2517/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2517 --build=9

@seldondev
Copy link
Collaborator

seldondev commented Nov 9, 2020 •
edited
Loading

@RafalSkolasinski: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 6f56653 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@RafalSkolasinski
Copy link
Contributor Author

There was some pr-build failure, looked like lint / licence related, I re-based onto master now.

@seldondev
Copy link
Collaborator

Mon Nov 9 17:27:55 UTC 2020
The logs for [lint] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2517/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2517 --build=11

@seldondev
Copy link
Collaborator

Mon Nov 9 17:28:22 UTC 2020
The logs for [pr-build] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2517/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2517 --build=10

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Tue Nov 10 13:21:29 UTC 2020
The logs for [lint] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2517/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2517 --build=13

@seldondev
Copy link
Collaborator

Tue Nov 10 13:21:43 UTC 2020
The logs for [pr-build] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2517/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2517 --build=12

@seldondev seldondev merged commit 4d704af into SeldonIO:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axsaucedo axsaucedo axsaucedo requested changes

Assignees

@axsaucedo axsaucedo

Labels
approved size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RafalSkolasinski @seldondev @axsaucedo