-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed AD Server Dependencies and Added notebook integration test #2536
Conversation
Thu Oct 8 14:55:13 UTC 2020 impatient try |
Thu Oct 8 14:55:15 UTC 2020 impatient try |
/test notebooks |
Thu Oct 8 15:59:59 UTC 2020 impatient try |
Thu Oct 8 16:00:23 UTC 2020 impatient try |
Thu Oct 8 16:03:09 UTC 2020 impatient try |
It seems failed tests are unrelated, namely the |
Thu Oct 8 18:24:13 UTC 2020 impatient try |
/test notebooks |
Thu Oct 8 19:49:37 UTC 2020 impatient try |
4f3c2dd
to
bd2ec59
Compare
/test notebooks |
Fri Oct 9 07:17:12 UTC 2020 impatient try |
Fri Oct 9 07:17:24 UTC 2020 impatient try |
Fri Oct 9 07:17:46 UTC 2020 impatient try |
/test this |
Fri Oct 9 07:38:33 UTC 2020 impatient try |
I just ran the custom_metrics test locally and works as expected, so seems it's due to flakiness |
/test notebooks |
Fri Oct 9 12:19:32 UTC 2020 impatient try |
@axsaucedo: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@axsaucedo I think I have the similar issue with my PR :( |
Ah just saw your comments :) thanks! |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2533
Fixes #2535
Special notes for your reviewer:
Does this PR introduce a user-facing change?: