-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update microservice.R for supporting jsonData input in R #2544
Conversation
Update functions in microservie.R to support "jsonData" input format like Python framework. An Example of "jsonData" input format : {"jsonData":{"key1":value1, "key2":value2}}
Hi @LueJian. Thanks for your PR. I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @cliveseldon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/ok-to-test |
Mon Oct 19 15:42:05 UTC 2020 impatient try |
Mon Oct 19 15:42:15 UTC 2020 impatient try |
Update functions in microservie.R to support "jsonData" input format like Python wrapper.
What this PR does / why we need it:
In R, we can use SeldonMessage with not only ndarray format, but also jsonData fromat now!
An example of "jsonData" input format : {"jsonData":{"key1":value1, "key2":value2}}
Which issue(s) this PR fixes:
Fixes #
Extending the concept from #595, supporting other language wrappers - R wrapper.
Special notes for your reviewer:
[Example] Testing it with a simple transformer-input component, just returning input as its output.
Does this PR introduce a user-facing change?: