Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update microservice.R for supporting jsonData input in R #2544

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

LueJian
Copy link
Contributor

@LueJian LueJian commented Oct 12, 2020

Update functions in microservie.R to support "jsonData" input format like Python wrapper.

What this PR does / why we need it:
In R, we can use SeldonMessage with not only ndarray format, but also jsonData fromat now!
An example of "jsonData" input format : {"jsonData":{"key1":value1, "key2":value2}}

Which issue(s) this PR fixes:

Fixes #

Extending the concept from #595, supporting other language wrappers - R wrapper.

Special notes for your reviewer:
[Example] Testing it with a simple transformer-input component, just returning input as its output.
jsonData input format testing

Does this PR introduce a user-facing change?:

None

Update functions in microservie.R to support "jsonData" input format like Python framework.
An Example of "jsonData" input format : {"jsonData":{"key1":value1, "key2":value2}}
@seldondev
Copy link
Collaborator

Hi @LueJian. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ryandawsonuk
You can assign the PR to them by writing /assign @ryandawsonuk in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LueJian
Copy link
Contributor Author

LueJian commented Oct 12, 2020

/assign @cliveseldon

@LueJian LueJian changed the title Update SeldonMessage with jsonData in R Update microsercer.R with supporting jsonData input in R Oct 13, 2020
@LueJian LueJian changed the title Update microsercer.R with supporting jsonData input in R Update microsercer.R for supporting jsonData input in R Oct 13, 2020
@LueJian LueJian changed the title Update microsercer.R for supporting jsonData input in R Update microservice.R for supporting jsonData input in R Oct 13, 2020
Copy link
Contributor

@ryandawsonuk ryandawsonuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@axsaucedo
Copy link
Contributor

/ok-to-test

@seldondev
Copy link
Collaborator

Mon Oct 19 15:42:05 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2544/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2544 --build=2

@seldondev
Copy link
Collaborator

Mon Oct 19 15:42:15 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2544/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2544 --build=1

@axsaucedo axsaucedo merged commit 5b1b2b1 into SeldonIO:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants