Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize mc image and fix access_key/secret_key #2619

Merged
merged 5 commits into from
Nov 6, 2020
Merged

Parameterize mc image and fix access_key/secret_key #2619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
24466a1
Add --api S3v4 to mc client
omerfsen Nov 6, 2020
c6fc58a
MINIO_SERVER_ACCESS_SECRET
omerfsen Nov 6, 2020
b517fbf
Update workflow.yaml
omerfsen Nov 6, 2020
bc828fb
Update workflow.yaml
omerfsen Nov 6, 2020
91d12f1
parameterize mc client image name
omerfsen Nov 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...ples/batch/argo-workflows-batch/helm-charts/seldon-batch-workflow/templates/workflow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ spec:

- name: download-object-store-template
script:
image: minio/mc:RELEASE.2020-04-17T08-55-48Z
image: minio/{{ .Values.minio.minioclient.image }}
env:
- name: MINIO_SERVER_ACCESS_KEY
valueFrom:
Expand All @@ -110,7 +110,7 @@ spec:
mountPath: /assets
command: [sh]
source: |
mc config host add minio-local $MINIO_SERVER_HOST $MINIO_SERVER_ACCESS_KEY $MINIO_SERVER_ACCESS_KEY
mc config host add minio-local $MINIO_SERVER_HOST $MINIO_SERVER_ACCESS_KEY $MINIO_SERVER_ACCESS_SECRET --api S3v4
mc cp minio-local/{{ .Values.minio.inputDataPath }} /assets/input-data.txt

- name: process-batch-inputs-template
Expand All @@ -137,7 +137,7 @@ spec:

- name: upload-object-store-template
script:
image: minio/mc:RELEASE.2020-04-17T08-55-48Z
image: minio/{{ .Values.minio.minioclient.image }}
volumeMounts:
- name: "{{ .Values.pvc.name }}"
mountPath: /assets
Expand All @@ -156,6 +156,6 @@ spec:
- name: MINIO_SERVER_HOST
value: {{ .Values.minio.endpoint }}
source: |
mc config host add minio-local $MINIO_SERVER_HOST $MINIO_SERVER_ACCESS_KEY $MINIO_SERVER_ACCESS_KEY
mc config host add minio-local $MINIO_SERVER_HOST $MINIO_SERVER_ACCESS_KEY $MINIO_SERVER_ACCESS_SECRET --api S3v4
mc cp /assets/output-data.txt minio-local/{{ .Values.minio.outputDataPath }}

3 changes: 3 additions & 0 deletions examples/batch/argo-workflows-batch/helm-charts/seldon-batch-workflow/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ batchWorker:
# Whether to enable benchmarking on the batch processor worker
enableBenchmark: true
minio:
# Minio Client (mc) Image name
minioclient:
image: mc:RELEASE.2020-10-03T02-54-56Z
# The location of the minio endpoint
endpoint: http://minio.minio-system.svc.cluster.local:9000
# This is the secret that should contain the values to access minio
Expand Down