Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Timeouts Notebook #2753

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Update Timeouts Notebook #2753

merged 1 commit into from
Dec 8, 2020

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

  • Update timeouts notebook to test on istio and tests REST and gRPC.

Istio actually has no default timeout so no need to add new code.

Which issue(s) this PR fixes:

Fixes #2727

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ukclivecox ukclivecox requested a review from axsaucedo December 8, 2020 14:36
@seldondev
Copy link
Collaborator

Tue Dec 8 14:37:44 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2753/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2753 --build=2

@seldondev
Copy link
Collaborator

Tue Dec 8 14:37:50 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2753/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2753 --build=1

@axsaucedo
Copy link
Contributor

Nice
/approve

@axsaucedo axsaucedo merged commit ad1dffa into SeldonIO:master Dec 8, 2020
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

istio request timeouts
3 participants