Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Namespace Override for seldon-core-operator #2762

Merged
merged 5 commits into from
Jan 11, 2021

Conversation

ntorba
Copy link

@ntorba ntorba commented Dec 10, 2020

What this PR does / why we need it:
This PR allows for users to override the namespace that the seldon-core-operator helm chart is installed into.
This is useful because when the helm chart is used as a dependency to other helm charts, you may not want it to be installed in the release namespace of the helm chart for which it is a dependency. Without this namespace override option, that is not possible.
Which issue(s) this PR fixes:

Fixes #2676

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Added support for namespace override in values of seldon-core-operator helm chart.

@seldondev
Copy link
Collaborator

Hi @ntorba. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@ntorba
Copy link
Author

ntorba commented Dec 10, 2020

/assign @RafalSkolasinski

@ukclivecox
Copy link
Contributor

/ok-to-test

@ukclivecox
Copy link
Contributor

/test integration

@ukclivecox
Copy link
Contributor

/test notebooks

@seldondev
Copy link
Collaborator

Mon Jan 4 15:53:23 UTC 2021
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2762/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2762 --build=2

@seldondev
Copy link
Collaborator

Mon Jan 4 15:53:30 UTC 2021
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2762/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2762 --build=3

@seldondev
Copy link
Collaborator

Mon Jan 4 15:53:33 UTC 2021
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2762/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2762 --build=1

@seldondev
Copy link
Collaborator

Mon Jan 4 15:53:45 UTC 2021
The logs for [notebooks] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2762/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2762 --build=4

@ukclivecox
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Mon Jan 11 18:54:52 UTC 2021
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2762/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2762 --build=5

@seldondev
Copy link
Collaborator

Mon Jan 11 18:55:03 UTC 2021
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2762/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2762 --build=6

@seldondev
Copy link
Collaborator

Mon Jan 11 19:07:47 UTC 2021
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2762/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2762 --build=7

@seldondev
Copy link
Collaborator

Mon Jan 11 19:07:59 UTC 2021
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2762/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2762 --build=8

@axsaucedo axsaucedo merged commit 97ca4a3 into SeldonIO:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seldon-core-operator Update for handling namespace
5 participants