-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Namespace Override for seldon-core-operator #2762
Conversation
@RafalSkolasinski, here are the updates requested on the pull request.
update with "" as default value
Hi @ntorba. Thanks for your PR. I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
/assign @RafalSkolasinski |
/ok-to-test |
/test integration |
/test notebooks |
Mon Jan 4 15:53:23 UTC 2021 impatient try |
Mon Jan 4 15:53:30 UTC 2021 impatient try |
Mon Jan 4 15:53:33 UTC 2021 impatient try |
Mon Jan 4 15:53:45 UTC 2021 impatient try |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cliveseldon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Mon Jan 11 18:54:52 UTC 2021 impatient try |
Mon Jan 11 18:55:03 UTC 2021 impatient try |
Mon Jan 11 19:07:47 UTC 2021 impatient try |
Mon Jan 11 19:07:59 UTC 2021 impatient try |
What this PR does / why we need it:
This PR allows for users to override the namespace that the seldon-core-operator helm chart is installed into.
This is useful because when the helm chart is used as a dependency to other helm charts, you may not want it to be installed in the release namespace of the helm chart for which it is a dependency. Without this namespace override option, that is not possible.
Which issue(s) this PR fixes:
Fixes #2676
Special notes for your reviewer:
Does this PR introduce a user-facing change?: