updated black version to 20.8b1 #2769

zyxue · 2020-12-11T18:29:34Z

updated and reran black on python/seldon_core and python/tests

Should black be run on all the pb2 files too like seldon_core/proto/prediction_pb2.py?

seldondev · 2020-12-11T18:29:37Z

Hi @zyxue. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

RafalSkolasinski · 2020-12-16T11:21:43Z

python/Makefile

@@ -95,7 +95,7 @@ push_conda:
 	@echo "Alternatively use anaconda upload to publish on own channel"

 setup_linter:
-	pip install black==19.3b0
+	pip install black==black 20.8b1


Is this a typo?

This should also be updated in requirements-dev.txt

thanks for the catch. updated

RafalSkolasinski · 2020-12-16T11:22:31Z

Nice one!

Should black be run on all the pb2 files too like seldon_core/proto/prediction_pb2.py?

As these are auto-generated by protos compiler I don't think they should be covered by black.

zyxue · 2020-12-16T16:09:05Z

Nice one!

Should black be run on all the pb2 files too like seldon_core/proto/prediction_pb2.py?

As these are auto-generated by protos compiler I don't think they should be covered by black.

I see. I used to format them for better readability, and also because black won't change the logic in anyway. But not blacking them sounds good too.

I've addressed your comments.

RafalSkolasinski · 2020-12-16T16:37:52Z

/ok-to-test

RafalSkolasinski · 2020-12-16T16:37:58Z

/test this

RafalSkolasinski · 2020-12-16T16:38:03Z

/test integration

seldondev · 2020-12-16T16:39:26Z

Wed Dec 16 16:39:25 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2769/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2769 --build=2

seldondev · 2020-12-16T16:39:38Z

Wed Dec 16 16:39:36 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2769/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2769 --build=3

seldondev · 2020-12-16T16:39:38Z

Wed Dec 16 16:39:35 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2769/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2769 --build=4

seldondev · 2020-12-16T16:39:39Z

Wed Dec 16 16:39:37 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2769/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2769 --build=1

RafalSkolasinski · 2020-12-16T17:33:53Z

/retest

seldondev · 2020-12-16T17:35:29Z

Wed Dec 16 17:35:25 UTC 2020
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2769/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2769 --build=5

zyxue · 2020-12-16T18:26:18Z

when can I see the log of the failed integration test?

RafalSkolasinski · 2020-12-16T19:41:13Z

there's a link in seldondev bot's message, they are available after the pipeline run

zyxue · 2020-12-16T23:58:40Z

https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2769/5.log

=================================== FAILURES ===================================
__________________________ TestPrepack.test_tfserving __________________________
[gw1] linux -- Python 3.6.10 /usr/local/bin/python

self = <test_prepackaged_servers.TestPrepack object at 0x7f28bc4376a0>
namespace = 'test-tfserving'

    def test_tfserving(self, namespace):
        spec = "../../servers/tfserving/samples/mnist_rest.yaml"
        retry_run(f"kubectl apply -f {spec}  -n {namespace}")
        wait_for_status("tfserving", namespace)
>       wait_for_rollout("tfserving", namespace)

test_prepackaged_servers.py:97: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

sdep_name = 'tfserving', namespace = 'test-tfserving', attempts = 50, sleep = 5
expected_deployments = 1

    def wait_for_rollout(
        sdep_name, namespace, attempts=50, sleep=5, expected_deployments=1
    ):
        deployment_names = []
        for _ in range(attempts):
            deployment_names = get_deployment_names(sdep_name, namespace)
            deployments = len(deployment_names)
    
            if deployments == expected_deployments:
                break
            time.sleep(sleep)
    
        error_msg = (
            f"Expected {expected_deployments} deployment(s) but got {len(deployment_names)}"
        )
        assert len(deployment_names) == expected_deployments, error_msg
    
        for deployment_name in deployment_names:
            logging.info(f"Waiting for deployment {deployment_name}")
            for _ in range(attempts):
                ret = run(
                    f"kubectl rollout status -n {namespace} deploy/{deployment_name}",
                    shell=True,
                )
                if ret.returncode == 0:
                    logging.info(f"Successfully waited for deployment {deployment_name}")
                    break
                logging.warning(
                    f"Unsuccessful wait command but retrying for {deployment_name}"
                )
                time.sleep(sleep)
            assert (
                ret.returncode == 0
>           ), f"Wait for rollout of {deployment_name} failed: non-zero return code"
E           AssertionError: Wait for rollout of tfserving-default-0-mnist-model failed: non-zero return code

seldon_e2e_utils.py:158: AssertionError

this seems have nothing to do with the chage here...

ukclivecox · 2020-12-17T10:18:36Z

Can you rebase as this failure is fixed

zyxue · 2020-12-17T16:54:17Z

rebased. Will tests be triggered automatically?

seldondev · 2020-12-17T16:55:28Z

Thu Dec 17 16:55:27 UTC 2020
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2769/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2769 --build=6

seldondev · 2020-12-17T16:55:34Z

Thu Dec 17 16:55:32 UTC 2020
The logs for [lint] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2769/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2769 --build=7

RafalSkolasinski · 2020-12-17T17:03:18Z

/test integration

seldondev · 2020-12-17T17:05:00Z

Thu Dec 17 17:04:59 UTC 2020
The logs for [integration] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2769/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2769 --build=8

zyxue · 2020-12-21T23:02:26Z

wondering if there is anything else that needs update for this PR?

RafalSkolasinski

Fantastic job!
/lgtm
/approve

RafalSkolasinski · 2021-01-04T11:54:30Z

/approve

RafalSkolasinski · 2021-01-04T11:54:35Z

/lgtm

seldondev · 2021-01-04T11:55:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RafalSkolasinski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [RafalSkolasinski]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

seldondev · 2021-01-04T11:56:50Z

Mon Jan 4 11:56:48 UTC 2021
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2769/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2769 --build=9

seldondev · 2021-01-04T11:56:51Z

Mon Jan 4 11:56:50 UTC 2021
The logs for [lint] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2769/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2769 --build=10

seldondev added the needs-ok-to-test label Dec 11, 2020

seldondev added the size/XS label Dec 11, 2020

RafalSkolasinski suggested changes Dec 16, 2020

View reviewed changes

seldondev assigned RafalSkolasinski Dec 16, 2020

seldondev added size/S and removed size/XS labels Dec 16, 2020

seldondev added ok-to-test and removed needs-ok-to-test labels Dec 16, 2020

zyxue added 5 commits December 17, 2020 08:53

updated black to black 20.8b1 in setup_linter

ae8f20a

reblacked code in seldon_core

8477056

corrected typo

87bcb35

added venv/ to .gitignore

1ea5525

newline

9478563

zyxue force-pushed the part-0-black branch from d718af1 to 9478563 Compare December 17, 2020 16:53

zyxue changed the title ~~updated black to black 20.8b1 in setup_linter~~ updated black version to 20.8b1 Dec 17, 2020

RafalSkolasinski self-requested a review January 4, 2021 11:53

RafalSkolasinski approved these changes Jan 4, 2021

View reviewed changes

seldondev added lgtm approved labels Jan 4, 2021

seldondev merged commit f89aa40 into SeldonIO:master Jan 4, 2021

RafalSkolasinski mentioned this pull request Jan 5, 2021

Enable customizable bins for TIMER metric #2713

Closed

zyxue deleted the part-0-black branch February 5, 2021 16:01

zyxue mentioned this pull request Feb 5, 2021

applied isort to seldon_core and tests #2927

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

updated black version to 20.8b1 #2769

updated black version to 20.8b1 #2769

zyxue commented Dec 11, 2020 •

edited

Loading

seldondev commented Dec 11, 2020

RafalSkolasinski Dec 16, 2020

RafalSkolasinski Dec 16, 2020 •

edited

Loading

zyxue Dec 16, 2020

RafalSkolasinski commented Dec 16, 2020

zyxue commented Dec 16, 2020

RafalSkolasinski commented Dec 16, 2020

RafalSkolasinski commented Dec 16, 2020

RafalSkolasinski commented Dec 16, 2020

seldondev commented Dec 16, 2020

seldondev commented Dec 16, 2020

seldondev commented Dec 16, 2020

seldondev commented Dec 16, 2020

RafalSkolasinski commented Dec 16, 2020

seldondev commented Dec 16, 2020

zyxue commented Dec 16, 2020

RafalSkolasinski commented Dec 16, 2020

zyxue commented Dec 16, 2020

ukclivecox commented Dec 17, 2020

zyxue commented Dec 17, 2020 •

edited

Loading

seldondev commented Dec 17, 2020

seldondev commented Dec 17, 2020

RafalSkolasinski commented Dec 17, 2020

seldondev commented Dec 17, 2020

zyxue commented Dec 21, 2020

RafalSkolasinski left a comment

RafalSkolasinski commented Jan 4, 2021

RafalSkolasinski commented Jan 4, 2021

seldondev commented Jan 4, 2021

seldondev commented Jan 4, 2021

seldondev commented Jan 4, 2021

updated black version to 20.8b1 #2769

updated black version to 20.8b1 #2769

Conversation

zyxue commented Dec 11, 2020 • edited Loading

seldondev commented Dec 11, 2020

RafalSkolasinski Dec 16, 2020

Choose a reason for hiding this comment

RafalSkolasinski Dec 16, 2020 • edited Loading

Choose a reason for hiding this comment

zyxue Dec 16, 2020

Choose a reason for hiding this comment

RafalSkolasinski commented Dec 16, 2020

zyxue commented Dec 16, 2020

RafalSkolasinski commented Dec 16, 2020

RafalSkolasinski commented Dec 16, 2020

RafalSkolasinski commented Dec 16, 2020

seldondev commented Dec 16, 2020

seldondev commented Dec 16, 2020

seldondev commented Dec 16, 2020

seldondev commented Dec 16, 2020

RafalSkolasinski commented Dec 16, 2020

seldondev commented Dec 16, 2020

zyxue commented Dec 16, 2020

RafalSkolasinski commented Dec 16, 2020

zyxue commented Dec 16, 2020

ukclivecox commented Dec 17, 2020

zyxue commented Dec 17, 2020 • edited Loading

seldondev commented Dec 17, 2020

seldondev commented Dec 17, 2020

RafalSkolasinski commented Dec 17, 2020

seldondev commented Dec 17, 2020

zyxue commented Dec 21, 2020

RafalSkolasinski left a comment

Choose a reason for hiding this comment

RafalSkolasinski commented Jan 4, 2021

RafalSkolasinski commented Jan 4, 2021

seldondev commented Jan 4, 2021

seldondev commented Jan 4, 2021

seldondev commented Jan 4, 2021

zyxue commented Dec 11, 2020 •

edited

Loading

RafalSkolasinski Dec 16, 2020 •

edited

Loading

zyxue commented Dec 17, 2020 •

edited

Loading