Add missing curl to engine Dockerfile #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrski
pushed a commit
that referenced
this pull request
Dec 2, 2022
* small update to docs * optimise computation of reserved memory * reconfigure model gateway for 1 consumer * kafka k8s config * update kafka config * add publish model as go routine * simplify goroutine call * add lock around sort and update to make it atomic * tidy up * remove pprof from scheduler * remove redundant struct * add a test for working out reserved memory * remove go routine * small mod to k8s Makefile * fix lint * add map for unique models * abstract add / delete to struct * add option for shallow copy * optimise create server status * fix test * add consistency lock for computing len * Revert "update kafka config" This reverts commit 2449d3cfbe0ac18e3050a28c9db9bc5890532aef. * Revert "small mod to k8s Makefile" This reverts commit 82a99bef126c15495157e4f062375926b81d9c10. * Revert "kafka k8s config" This reverts commit ee6b5dddb0fd1ffc3c9cdcb9b552494ac9fe39cd. * Revert "reconfigure model gateway for 1 consumer" This reverts commit e3295fa3792aeaaa1b0fdacad6d225ced5973710. * Review comments * add note about object leakage * add simple test * fix lint Co-authored-by: Clive Cox <cc@seldon.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used in preStop to get Tomcat server to pause and no longer be "ready"
Fixes #283