Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAB Distributed Persistence with Redis #2936

Merged
merged 3 commits into from
Feb 25, 2021

Conversation

axsaucedo
Copy link
Contributor

What this PR does / why we need it:

Initial exploration of distributed state persistence for online models. Implemented persistence for MAB TS usecase.

This PR extends the MAB case study to show how redis can be used to store and share state across multiple replicas (and across restarts).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@axsaucedo axsaucedo requested a review from ukclivecox February 8, 2021 19:13
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign axsaucedo
You can assign the PR to them by writing /assign @axsaucedo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox ukclivecox merged commit cc039b2 into SeldonIO:master Feb 25, 2021
@seldondev
Copy link
Collaborator

failed to trigger Pull Request pipeline

  • failed to create agent
  • failed to calculate in repo config
  • failed to load trigger config for repository SeldonIO/seldon-core for ref 48a43bc
  • failed to find any lighthouse configuration files in repo SeldonIO/seldon-core at sha 48a43bc
  • failed to process repo SeldonIO/seldon-core refref 48a43bc
  • failed to list files in directory /var/tmp/gitrepo799923688/.lighthouse
  • open /var/tmp/gitrepo799923688/.lighthouse
  • no such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants