Depricate persistence

[nadinet]

What this PR does / why we need it:
Remove "PERSISTENCE" Redis functionality and documentation.
"soft" deprication, flag is ignored.
Which issue(s) this PR fixes:

Fixes #2888

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[seldondev]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign axsaucedo
You can assign the PR to them by writing /assign @axsaucedo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[adriangonz]

Nice one @nadinet! We may also need to re-generate the licenses information to remove all the redis licensing info.

[adriangonz]

/test integration

[adriangonz]

/test notebooks

[adriangonz]

@nadinet should we also remove the --persistence reference from the s2i/bin/run script in the S2I Python wrapper template?

seldon-core/wrappers/s2i/python/s2i/bin/run

Line 47 in 228b417

exec seldon-core-microservice $MODEL_NAME --service-type $SERVICE_TYPE --persistence $PERSISTENCE

I just realised that the same script also forces for the PERSISTENCE flag to be present, so maybe that's one we can also remove:

seldon-core/wrappers/s2i/python/s2i/bin/run

Lines 24 to 30 in 228b417

	#check environment vars
	if [[ -z "$MODEL_NAME" || -z "$SERVICE_TYPE" || -z "$PERSISTENCE" ]]; then
	echo "Failed to find required env vars MODEL_NAME, SERVICE_TYPE, PERSISTENCE"
	exit 1
	else

[adriangonz]

/test integration

[adriangonz]

/test notebooks

[axsaucedo]

/test integration

[axsaucedo]

/test notebooks

[axsaucedo]

Incorrect syntax

[axsaucedo]

/test integration

[axsaucedo]

/test notebooks

[axsaucedo]

It seems the tests have found a couple of issues:

On the integration tests it failed because mlflow server seems to re-install the older version of seldon core

Basically showing error importing redis

Fixed by removing extra installation, and uses the base dependency correctly

On the notebooks tests it's one test failed

The failed test also has an mlfow server run at the bottom, ran the rest of the examples successfully

[axsaucedo]

/test integration

[axsaucedo]

/test notebooks

[RafalSkolasinski]

/test integration

[axsaucedo]

/test notebooks

[axsaucedo]

/test integration

[axsaucedo]

/test notebooks

[axsaucedo]

/test integration

[axsaucedo]

/test integration

[axsaucedo]

/test integration

[axsaucedo]

/test integration

[adriangonz]

/test integration

[RafalSkolasinski]

/test integration

[RafalSkolasinski]

Just to check if changes in original mlflow bucket managed to propagate
/test notebooks